Closed
Bug 531078
Opened 15 years ago
Closed 8 years ago
Selected text background is the wrong color when window is not focused
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: stefanh)
Details
Attachments
(1 file)
|
2.27 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
In text areas selected text has a white background when it should be light grey. In regular content selected text has a dark grey background when it should be light grey.
|
||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
|
|
||
Comment 2•15 years ago
|
||
Hmm, ok, the second issue is actually not covered by bug 141007.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
|
Assignee | |
Comment 3•8 years ago
|
||
So we're not using a system color here, instead we're using the same (hardcoded) color for all platforms: https://dxr.mozilla.org/mozilla-central/rev/5e76768327660437bf3486554ad318e4b70276e1/widget/nsXPLookAndFeel.cpp#775 Looking at webkit, it seems they're using the NSColor secondarySelectedControlColor which is lighter: https://github.com/WebKit/webkit/blob/1f6436eabdb0d90e04bad8af2c9ba50c6b6c8f98/Source/WebCore/rendering/RenderThemeMac.mm#L301
Assignee: nobody → stefanh
Status: REOPENED → NEW
|
|
Assignee | |
Comment 4•8 years ago
|
||
Not sure if it's better to move everything to each platform-specific nsLookAndFeel file instead of the #ifndef... This is a bit more economical, though.
Attachment #8810987 -
Flags: review?(mstange)
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8810987 [details] [diff] [review] Use MacOS system color for selected text background in inactive windows Review of attachment 8810987 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay, this looks good.
Attachment #8810987 -
Flags: review?(mstange) → review+
Pushed by stefanh@inbox.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/befc69f2cf27 Use MacOS system color for selected text background in inactive windows. r=mstange.
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/befc69f2cf27
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•7 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•