Closed Bug 531107 Opened 15 years ago Closed 15 years ago

[Windows] Enabling a extension results in "deep recursion on subroutine" warnings

Categories

(Bugzilla :: Extensions, defect)

3.5.2
All
Windows Server 2008
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: mockodin, Assigned: mkanat)

References

Details

Attachments

(2 files)

Also Applies to Windows 7 (and likely Windows Vista)

Code Base: CVS TIP 3.5.2+

Reproducible Always

To Reproduce:
1. delete extensions/Example/disabled
2. Run checksetup or if in a mod_perl environment apache -t

Results:
Deep recursion on subroutine "Bugzilla::Extension::__do_call" at Bugzilla/Extension.pm line 189.
Deep recursion on subroutine "Bugzilla::Extension::__do_call" at Bugzilla/Extension.pm line 159.
Deep recursion on anonymous subroutine at C:/usr/lib/File/Spec/Win32.pm line 92.
Deep recursion on subroutine "Bugzilla::Extension::__do_call" at Bugzilla/Extension.pm line 153.
Deep recursion on subroutine "Bugzilla::Extension::my_inc" at Bugzilla/Extension.pm line 210.
Deep recursion on subroutine "File::Spec::Win32::case_tolerant" at Bugzilla/Extension.pm line 166.

Followed by windows "Perl Command Line Interpreter has stopped working"

Notes:
If no extensions are enable, no errors occur.
I can reproduce this problem on Windows 7, but not on Linux.
Target Milestone: --- → Bugzilla 3.6
Severity: blocker → critical
Hardware: x86 → All
Summary: Enabling a extension results in Perl Command Line Interpreter has stopped working with Deep recursion on subroutine warnings → [Windows] Enabling a extension results in "deep recursion on subroutine" warnings
Depends on: bz-hooks-rewrite
Yeah, I can reproduce it too. It's probably somehow related to the path stuff that Extensions do. I'll look at it tonight or tomorrow if I get the chance.
Attached patch v1Splinter Review
Okay, this fixes it in my testing. mockodin, would you let me know if it fixes it for you? I think that since I'm the Extensions owner, that will be enough review to check in this fix.
Assignee: extensions → mkanat
Status: NEW → ASSIGNED
Attachment #415321 - Flags: review?(mockodin)
Looks good. Apache is now starting properly. Thanks MKanat.
Attachment #415321 - Flags: review?(mockodin) → review+
Checking in Bugzilla/Extension.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Extension.pm,v  <--  Extension.pm
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
This bug has no approval+, for the record. ;)
Flags: approval?
Oh, thanks, LpSolit. :-)
Flags: approval? → approval+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: