53160 - cleanup for sidebar panel preview

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

I have made some changes to the sidebar panel preview dialog that reduce the
form factor somewhat and remove an unusual UI element (the close button). These
changes are r=matt. I believe paul hangas indicated willingness to sr. if a
nsbeta3+ bug was available.

Comment 1

[Phil Peterson]

Need info on whether these changes have been approved by sidebar folks (cc'ing 
johng) and are really required.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Here's an itemised description of the changes:

- The Preview dialog's <window> tag was using class="dialog", which forced a 5px
or so margin around the content area. I replaced this with class="color-dialog"
which was more aeshetically pleasing. (removed the 5px margin).
- The Preview dialog had a groove horizontal separator underneath the sidebar
panel it was previewing, and underneath that, a "Close" button. This is
nonstandard UI for floating palette windows such as this on Mac and Windows, so
I removed both. The standard method of closing such windows is using the close
button.

Comment 3

[don]

Do you already have the fix for this?  If so, then I can make it "nsbeta3+" if
you can get it in before the branch.

Comment 4

[don]

OK, Ben has the code already written and reviewed.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: appearance tidy up

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

fix checked in.

Comment 7

[shrirang khanzode]

verified (2000928 br all plfs)