531766 - Download button JS needs to be refactored into an existing js file

Status: RESOLVED WONTFIX

(Camino Graveyard :: Product Site, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The code that selects the correct URL for the Download button has a couple of problems:

1) It exists as separate inline js on at least two pages (Home and Features)
2) The version number is hard-coded in the URL string

The code needs to be pulled out of the pages and stuck in a common JS file.  It also needs to be refactored to pull the current version number from somewhere else so it's not *one more thing* to have to change each time.  (ua-messages.js already has a widely-used variable for current version.)

I think I'd like to see this js pulled into ua-detect for the detection and ua-messages for the button url writing (since both are currently included by all pages already).

Comment 1

[Samuel Sidler (old account; do not CC)]

I wouldn't block 2.0.1 on this, but I'll put it high-ish on my list and try and get to it this week.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Features also includes a hard-coded version number in the default/non-js button's URL (Home, mercifully, doesn't).  

Maybe these buttons (and other download links on the site) want htaccess rules and dummy URLs like download/latest/ and download/latest-MultiLang/ ?  I suppose that would also help with spidering?

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> (and other download links on the site)

Such as the buttons on Downloads.

Comment 4

[Samuel Sidler (:ss)]

(In reply to comment #2)
> Features also includes a hard-coded version number in the default/non-js
> button's URL (Home, mercifully, doesn't).  

This wasn't supposed to be. The JS rewriting we do should be sufficient here. I failed in my copy-paste, likely.

> Maybe these buttons (and other download links on the site) want htaccess rules
> and dummy URLs like download/latest/ and download/latest-MultiLang/ ?  I
> suppose that would also help with spidering?

Naw, we're good. I just need to call the JS file that we already include that has this data. We're doing that now on home and features, but the JS is still inline. Working on that.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We might also want to take advantage of latestReleaseOS (bug 609090) here.

Comment 6

[Samuel Sidler (:ss)]

Given the current state of the Camino project, we won't be fixing these website bugs. Mass changing our Product Site bugs (search on "camino-website-bugs").

RESOLVED -> WONTFIX.