532233 - Should JSOPTION_ANONFUNFIX be on by default in the shell?

Status: RESOLVED DUPLICATE of bug 595555

(Core :: JavaScript Engine, defect)

Comment 1

[Jim Blandy :jimb]

I was tracking down why a test I'd written passed under the shell, but failed under jsreftests.  The reason was that I'd used a form like this:

    function(x,y){}

When JSOPTION_ANONFUNFIX is set, this is flagged as a syntax error.  JSOPTION_ANONFUNFIX is set by default in the browser, but cleared by default in the shell.  Is there a rationale for keeping it this way?  It seems to me that, absent some compelling reason, it serves our purpose best for shell and browser to be aligned.

I understand why, for example, 'let' and 'yield' must be disabled by default in the browser, and I think it's correct that they're enabled in the shell.  The shell should reflect the latest and greatest version of the language, and the test harness manages this.  But JSOPTION_ANONFUNFIX seems like a distinct axis, and I don't see why browser and shell should sit at different points on that axis.

Comment 2

[Brendan Eich [:brendan]]

I think I just plain forgot to flip the option for the shell when it was set for the browser. Digging... argh, cvs time... Yup, sorry about that:

revision 1.321
date: 2007/04/13 23:06:40;  author: brendan%mozilla.org;  state: Exp;  lines: +1 -0
Set JSOPTION_ANONFUNFIX as one of the default options (377433, r+sr=jst).

No shell change AFAIK. Please do fix this oversight. Thanks,

/be