532309 - Application specific search returns results for other applications

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect, P3)

Description

[Eric Moore]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4
Build Identifier: 

If I select Thunderbird as the application on the Mozilla Add-ons web site and then search for something it frequently returns add-ons for both Thunderbird and Firefox despite the fact that the web site clearly identifies itself as "Add-ons for Thunderbird".

I'm not talking about returning the wrong web page when an add-on exists for both Thunderbird and Firefox or a confusing web page for an add-on that works for both applications. I mean add-ons that are not available for Thunderbird.

For example, search for tabs. It returns 21 add-ons. The search results include

https://addons.mozilla.org/en-US/firefox/addon/10828 (New Tab King)
https://addons.mozilla.org/en-US/firefox/addon/13720/ (Inline Browser)
https://addons.mozilla.org/en-US/firefox/addon/5142 (Print All Tabs)
https://addons.mozilla.org/en-US/firefox/addon/7643 (Prevent duplicate tabs)
https://addons.mozilla.org/en-US/firefox/addon/3662 (RemoveX - tab-menu remover)
https://addons.mozilla.org/en-US/firefox/addon/7606 (Lathe2)
https://addons.mozilla.org/en-US/firefox/addon/13670 (Ebay calendar)

https://addons.mozilla.org/en-US/thunderbird/addon/10868 (Mozilla Labs - Weave Sync)
This is listed as a Thunderbird add-on but its not clear that it really is one. It seems like an add-on for Firefox 3.5 or later. 

https://addons.mozilla.org/en-US/thunderbird/addon/7607 (Blues for Peace toolbar)
It does not specify what version it supports. This is listed as a Thunderbird add-on but its not clear that it really is a Thunderbird add-on

https://addons.mozilla.org/en-US/thunderbird/addon/11642 (Ultimate-Guitar.com search plugin)
It does not specify what version it supports. This is listed as a Thunderbird add-on but its not clear it really is one.

My impression is that application specific searches aren't, and that if that bug is fixed there is still a problem due to the database incorrectly identifying some add-ons as Thunderbrid add-ons.
 


Reproducible: Always

Comment 1

[Fred Wenzel [:wenzel]]

I can reproduce. Dave Dash, can you take a look?

Comment 2

[Justin Scott [:fligtar]]

I think this is almost the same as bug 532988. See discussion there for possible solution.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Everything looks fine except for:

Linky


and 

New Tab from here.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Fixed via http://github.com/jbalogh/zamboni/commits/0a21890

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Hey Eric -

Looks fixed to me on https://preview.addons.mozilla.org/z/en-US/thunderbird/search/?q=tabs&cat=all&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced=

Mind double-checking?  Thanks!

Comment 7

[Eric Moore]

Much better but that search still returns

(Ultimate-Guitar.com search plugin  20090425)
https://preview.addons.mozilla.org/z/en-US/firefox/addon/11642/

I also tried searching for filter on the preview version of the web site.
https://preview.addons.mozilla.org/z/en-US/thunderbird/search/?q=filter&cat=all&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced=

It returns several firefox/search add-ons

(guiGoog1.2b  20090825)
https://preview.addons.mozilla.org/z/en-US/firefox/addon/13915/

(עץ הדטה - חיפוש ישראלי ממוקד  20100101)
https://preview.addons.mozilla.org/z/en-US/firefox/addon/14356/

(Octoprice shopping search & comparison engine  20081030)
https://preview.addons.mozilla.org/z/en-US/firefox/addon/9431/

(Nigma Search  20090421)
https://preview.addons.mozilla.org/z/en-US/firefox/addon/11533/

(FileDigg - pdf search engine  20100108)
https://preview.addons.mozilla.org/z/en-US/firefox/addon/12373/

It looks like the only remaining problem is its still returning Firefox search add-ons when you search Thunderbird add-ons.

Comment 8

[Wil Clouser [:clouserw]]

Ok, this bug is now "Search returns search engine add-ons that aren't compatible with the current application."  -> 4.x

Comment 9

[Pratibha]

Searching for "Tab" returns Firefox add-on with Add to Firefox button:
https://addons.mozilla.org/en-US/firefox/addon/10142/

Comment 11

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Ah... 

http://github.com/jbalogh/zamboni/commit/915ce24

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment 7 and comment 9 look fixed to me.

Doing some regression-testing around search, but the fix looks good to me.

Verified FIXED.