532805 - Download page's buttons have float issues

Status: RESOLVED FIXED

(Camino Graveyard :: Product Site, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Like bug 529752, text size and whatnot affect the alignment of the buttons and text on the Download page.  I'm sure this is more floating fun.

Comment 1

[philippe (part-time)]

What exactly are the issues you see/want fixed ?

At present, what I see is that a larger font-size, the gray text next to the 'Multilingual' button wraps under the image - the same would happen if you include more text, 3 lines worth or more.

A very quick and __dirty__ fix is to give the #download p img a margin-bottom, something like 2em. That would allow _some_ level of larger font-size or amount of text next to the button.

A better fix would be to start with a better html structure (an unordered list seems most appropriate… :-)) and styling. The styling depends a little on what you want to happen exactly.

(and also, does the whole construct need to one <a> block for each of the two items ? that complicate things a little if we want to avoid a couple of Gecko bugs … !)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> At present, what I see is that a larger font-size, the gray text next to the
> 'Multilingual' button wraps under the image - the same would happen if you
> include more text, 3 lines worth or more.

And with a smaller font size, the the ML button can end up under the text for the English download.

Ideally I'd like to see the button and the text be two "boxes" that are always horizontally centered on each other.

Comment 3

[Samuel Sidler (old account; do not CC)]

We can fix the markup. I think a table works well here. ;)

Comment 4

[philippe (part-time)]

Something like this ?
http://dev.l-c-n.com/camino/cm_download.html

Comment 5

[philippe (part-time)]

Attachment: css + html changes

The reshuffle for comment 4 in plain text format.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yeah, that page looks good to me.  I'm not sure I understand the comments in the CSS; can you post a diff instead?

diff -U 8 src.php new.php > diff_file.diff
diff -U 8 src.css new.css >> diff_file.diff

Comment 7

[philippe (part-time)]

Attachment: html.diff

Comment 8

[philippe (part-time)]

Attachment: css.diff

Comment 9

[philippe (part-time)]

btw, the links on those buttons should probably point to /releases/2.0.1/
(on the live site, they still point to /releases/2.0/)

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Thanks.  I pushed this change and the missed 2.0.1 bit :/