533580 - strip busted tbird support

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Mike Connor [:mconnor]]

We should figure out what, if anything, should be synced with Thunderbird, but not for 1.0.

Comment 1

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/5519943c948d

If there's interest in doing something interesting here at some point, someone should file a bug.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

The sync.xul change broke SeaMonkey integration. :-(

Clicking on the Weave status bar entry in SeaMonkey (using left or right mouse click) now triggers this in the Error Console with Weave 1.0b3:

Error: menuPopup is null
Source: chrome://weave/content/sync.js
Line: 381

which is
  if (menuPopup.parentNode != menuButton)
where menuPopup is
  var menuPopup = document.getElementById('sync-menu-popup');
cf. sync.xul for the rest.

Granted, the comment said it's only for TB...

Mike, can you please revert that change (adapting the comment to read SeaMonkey)? I have no Weave source tree around so it would require me some time to prepare a clean patch.

Comment 3

[Philip Chee]

Attachment: patch Sv1.0 Fix SeaMonkey breakage.

This fixes the SeaMonkey Tools menu item for me.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 417271 [details] [diff] [review]
patch Sv1.0 Fix SeaMonkey breakage.

Heh, oops.