Closed
Bug 533592
Opened 15 years ago
Closed 14 years ago
Get rid of xpcnativewrappers=no
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: mrbkap, Assigned: jorendorff)
References
Details
(Keywords: dev-doc-complete, Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files)
19.58 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
9.96 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
In order to make the decision "what type of wrapper should I create for this object?" depend only on the scope we're looking at and the object (and its scope), we need to do this.
Comment 2•15 years ago
|
||
xpcnativewrappers=no was a temporary measure to allow addons to transition to using .wrappedJSObject in the places where they really needed to examine expando properties. If any haven't done so by now, they should.
Reporter | ||
Updated•15 years ago
|
Blocks: blazinglyfastthis
Assignee | ||
Comment 3•14 years ago
|
||
Getting rid of this will allow us to get rid of the BYPASS code in XPCNativeWrapper.cpp, which is necessary for compartmentalization. Taking.
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #447716 -
Flags: review?(mrbkap)
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #447717 -
Flags: review?(mrbkap)
Reporter | ||
Updated•14 years ago
|
Attachment #447716 -
Flags: review?(mrbkap) → review+
Reporter | ||
Updated•14 years ago
|
Attachment #447717 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Ran these through Try Server along with the patches in bug 568379, and it came back beautifully green. :)
Assignee | ||
Comment 7•14 years ago
|
||
Part 1: http://hg.mozilla.org/tracemonkey/rev/1bc36f4d8ea3 Part 2: http://hg.mozilla.org/tracemonkey/rev/8c42fc73321a
Whiteboard: fixed-in-tracemonkey
Updated•14 years ago
|
Keywords: dev-doc-needed
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1bc36f4d8ea3
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 9•14 years ago
|
||
For the reference: http://blog.mozilla.com/mrbkap/2010/02/11/xpcnativewrappersno-going-away/ I mentioned this bug at https://developer.mozilla.org/en/Chrome_Registration#xpcnativewrappers for now. Ideally we'd have a migration guide.
Target Milestone: --- → mozilla1.9.3a5
Comment 10•14 years ago
|
||
Added a note to the XPCOM changes in Firefox 4 page: https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_2.0#XPCNativeWrapper_changes Can anyone explain to me exactly how someone would go about updating their code? I have no clue where to even start here.
Comment 11•14 years ago
|
||
I transcribed info from mrbkap's blog post to the XPCOM changes in Gecko 2.0 page, but we could still use a good step-by-step migration guide.
Comment 13•14 years ago
|
||
Updated more stuff, calling this done.
Keywords: dev-doc-needed → dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•