533713 - gdata-provider.xpi should support SeaMonkey 2

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Tony Mechelynck [:tonymec]]

Now that Lightning comm-1.9.1 builds support (among others) SeaMonkey 2 (minVersion = 2.0b2, maxVersion = 2.0.2pre), the gdata-provider.xpi builds found in the same FTP directories as these lightning.xpi builds should support the same applications.

I could install gdata-provider.xpi 0.6pre together with Lightning 1.0b2pre in:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7pre) Gecko/20091209 Lightning/1.0b2pre SeaMonkey/2.0.2pre
- Build ID: 20091209000712

but for gdata-provider (not for Lightning) I had to override the version compatibility, and the addons manager says it is "Not compatible with SeaMonkey 2.0.2pre".

Comment 1

[Tony Mechelynck [:tonymec]]

P.S. The actual Lightning and gdata-provider builds I installed were the tinderbox-builds dated 2009-12-09 09:27 UTC, from ftp://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/tinderbox-builds/comm-1.9.1/linux-xpi-linux/1260353473/

Comment 2

[Martin Schröder [:mschroeder]]

Attachment: Patch for comm-central

Comment 3

[Martin Schröder [:mschroeder]]

Attachment: Patch for comm-1.9.1

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 416914 [details] [diff] [review]
Patch for comm-central

We don't have SEAMONKEY_VERSION defined in the makefile. I'll upload patches that fix the issue in a moment.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Patch for comm-central - v2

I'm also bumping the gdata version to 0.7pre for trunk

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/9cd357660da2>


-> FIXED

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Sorry about this, but the checkins on 1.9.1 for this are quite a mess. Mostly due to the fact that I was tired and in a hurry.

Summary of what the status is now:

* relbranch: changed min/maxVersions similar to what was done for Lightning
* relbranch: changed version to 0.6b1
* default: changed min/maxVersions to @SEAMONKEY_VERSION@
* default: changed version to 0.6b2pre

Now the mess of revids on comm-1.9.1

relbranch: 92f94a04799e af2006a75975 77a5ba0f4d1b 1a39e19621ff
default: 3fbcb74e85ca 2002ab9c8bc4 daf3188c3e3f

I promise I'll be more careful next time!

Comment 8

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7pre) Gecko/20091212 Lightning/1.0b2pre SeaMonkey/2.0.2pre - Build ID: 20091212001002

with Lightning & gdata-provider builds from ftp://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/tinderbox-builds/comm-1.9.1/linux-xpi-linux/1260650303/ dated 2009-12-12 19:56 UTC

Addons Manager doesn't say "Incompatible with SeaMonkey 2.0.2pre" anymore (in fact, _this_ build supports _only_ Sm 2.0.2pre: why not at least 2.0b2 to 2.0.2pre like Lightning, or even 2.0b2 to 2.0.* ? well, that's not for me to decide).
=> verified1.9.1

I don't use comm-central versions yet, someone else please verify that.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".