Closed
Bug 534361
Opened 15 years ago
Closed 15 years ago
Crash at [@ nsObjectLoadingContent::Instantiate(nsIObjectFrame*, nsACString_internal const&, nsIURI*)]
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(status1.9.2 final-fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | final-fixed |
People
(Reporter: sicking, Assigned: sicking)
Details
(Keywords: crash, topcrash, Whiteboard: [crashkill][crashkill-fix])
Crash Data
Attachments
(1 file)
1.51 KB,
patch
|
jst
:
review+
jst
:
approval1.9.2+
|
Details | Diff | Splinter Review |
Looks like we're crashing after having instantiated the plugin when trying to get the instance out of the frame. Possibly the frame is going away while we're instantiating. Writing up a patch to deal with that.
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → jonas
Assignee | ||
Comment 1•15 years ago
|
||
Specifically we're crashing here: http://hg.mozilla.org/releases/mozilla-1.9.2/annotate/4c488520d1bf/content/base/src/nsObjectLoadingContent.cpp#l1768
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #417222 -
Flags: review?(joshmoz)
Assignee | ||
Comment 3•15 years ago
|
||
Basically what i suspect is happening is that the instantiate call spins the event loop, and during this something causes the frame to go away.
Whiteboard: [crashkill]
Comment 4•15 years ago
|
||
Comment on attachment 417222 [details] [diff] [review] This might fix it r=jst (josh, feel free to have a look still)
Attachment #417222 -
Flags: review?(joshmoz) → review+
Severity: normal → critical
Keywords: crash
Summary: Crash at [@nsObjectLoadingContent::Instantiate(nsIObjectFrame*, nsACString_internal const&, nsIURI*)] → Crash at [@ nsObjectLoadingContent::Instantiate(nsIObjectFrame*, nsACString_internal const&, nsIURI*)]
Do we want this on 1.9.2?
Assignee | ||
Updated•15 years ago
|
Attachment #417222 -
Flags: approval1.9.2?
Assignee | ||
Comment 6•15 years ago
|
||
Yes we do Fixed on trunk http://hg.mozilla.org/mozilla-central/rev/4b8ffbe9a4c4
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Whiteboard: [crashkill] → [crashkill][crashkill-fix]
Updated•15 years ago
|
Attachment #417222 -
Flags: approval1.9.2? → approval1.9.2+
Assignee | ||
Comment 7•15 years ago
|
||
Fixed on 1.9.2 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5e9329cfac70
status1.9.2:
--- → final-fixed
Updated•13 years ago
|
Crash Signature: [@ nsObjectLoadingContent::Instantiate(nsIObjectFrame*, nsACString_internal const&, nsIURI*)]
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•