535092 - Failed to build Thunderbird trunk in Solaris

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Boying Lu]

When tried to build latest TB trunk code, I got following error:
comm-central/configure: test: unknown operator ==

The root cause is that /bin/sh is not bash on Solaris

Comment 1

[Boying Lu]

Attachment: Use "=" instead of "=="

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 417880 [details] [diff] [review]
Use "=" instead of "=="

Stealing review - sorry it was my fault when I checked in a quick bustage fix yesterday.

r=Standard8

Comment 3

[Wan-Teh Chang]

Comment on attachment 417880 [details] [diff] [review]
Use "=" instead of "=="

r=wtc.

Comment 4

[Ilja Sekler]

Removing the bashism fixes also linking failure of thunderbird-bin on Ubuntu (/usr/bin/ld: cannot find -lmozsqlite3).

Comment 5

[Boying Lu]

(In reply to comment #4)
> Removing the bashism fixes also linking failure of thunderbird-bin on Ubuntu
> (/usr/bin/ld: cannot find -lmozsqlite3).

I tried the latest trunk code + my patch on ubuntu 9.10. It works well.
Can you tell me how to re-produce the error?

Comment 6

[Ilja Sekler]

(In reply to comment #5)

> I tried the latest trunk code + my patch on ubuntu 9.10. It works well.
> Can you tell me how to re-produce the error?

Sorry if my wording was unclear: your patch removes the bashism, fixing the build on Ubuntu. Different from Solaris, there is no error on configure, the check just fails silently, the build fails first when trying to link thunderbird-bin about an hour later.

To reproduce the error: don't apply the patch ;-)

Can anything be done to expedite the checkin?

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #6)
> Can anything be done to expedite the checkin?

Normally I'd expect checkin-needed to be added to the keywords if Boying can't do it himself.

Anyway, checked this in:

http://hg.mozilla.org/comm-central/rev/2785b74de5c0