Closed
Bug 535629
Opened 15 years ago
Closed 14 years ago
Deleted properties' slots are not recycled
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla2.0
People
(Reporter: jorendorff, Assigned: brendan)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 2 obsolete files)
|
4.36 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
We could compact them during GC or keep a freelist threaded through the vacant slots.
|
Assignee | |
Updated•14 years ago
|
Assignee: general → brendan
Status: NEW → ASSIGNED
Depends on: 558451
Priority: -- → P2
Target Milestone: --- → mozilla2.0
|
|
Assignee | |
Comment 1•14 years ago
|
||
No rush on review. Should be a relief to do this after recovery from bug 558451 patch queue review. /be
Attachment #467027 -
Flags: review?(jorendorff)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #467027 -
Attachment is obsolete: true
Attachment #467197 -
Flags: review?(jorendorff)
Attachment #467027 -
Flags: review?(jorendorff)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Bite-sized, too! /be
Attachment #467197 -
Attachment is obsolete: true
Attachment #470506 -
Flags: review?(jorendorff)
Attachment #467197 -
Flags: review?(jorendorff)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 470506 [details] [diff] [review] rebased to tm tip just now Giving Jason a break again, and Andreas has always wanted to see this fixed, so... /be
Attachment #470506 -
Flags: review?(jorendorff) → review?(gal)
|
||
Comment 5•14 years ago
|
||
This duplicates some code that could be commoned out.
|
|
||
Updated•14 years ago
|
Attachment #470506 -
Flags: review?(gal) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
(In reply to comment #5) > This duplicates some code that could be commoned out. Andreas couldn't cite that code so I'm going with the patch as attached :-P. /be
|
|
Assignee | |
Comment 7•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/cb719643afc5 /be
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/cb719643afc5 /be
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•