535908 - Patch for bug 396680 breaks 64-bit builds on SnowLeopard

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

My patch for bug 396680 breaks 64-bit builds.  They die with the
following link errors:

Undefined symbols:
  "_OBJC_CLASS_$_PDEPluginCallback", referenced from:
      l_OBJC_$_CATEGORY_PDEPluginCallback_$_MethodSwizzling
        in libwidget_mac.a(nsAppShell.o)
      __objc_classrefs__DATA@0 in libwidget_mac.a(nsAppShell.o)
  "_OBJC_IVAR_$_PDEPluginCallback._printWindowController", referenced from:
      -[PDEPluginCallback(MethodSwizzling)
        nsAppShell_PDEPluginCallback_dealloc]
        in libwidget_mac.a(nsAppShell.o)
ld: symbol(s) not found

These are caused by a change in the behavior of gcc:  The errors don't
happen when using gcc 4.2 to compile a 32-bit build on OS X 10.5.8.  I
haven't yet tried a 32-bit build (with gcc 4.2) on SnowLeopard.

The solution is to use a lower-level method to access the
PDEPluginCallback class's _printWindowController variable.

I'll post a patch in my next comment.

Thanks to Joel Reymont for pointing this out to me via email.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Attachment: Fix/workaround

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I've tested this patch in a 32-bit build on OS X 10.5.8.  It has
exactly the same functionality as the previous code -- it still fixes
bug 396680, without introducing any new problems.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

The link errors don't happen doing a 32-bit build on SnowLeopard.  So they only happen doing 64-bit builds.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Joel, please test my patch and let us know your results.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Landed on trunk:
http://hg.mozilla.org/mozilla-central/rev/4ad1dfc25ea7

Comment 6

[Joel Reymont (:joelr)]

Builds fine on x86-64.