535911 - "ASSERTION: aParentFrame has later continuations with kids?" with -moz-column

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: aParentFrame has later continuations with kids?: 'nextSibling || !aParentFrame->GetNextContinuation() || !aParentFrame->GetNextContinuation()->GetFirstChild(nsnull)', file /Users/jruderman/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 5792

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is effectively a regression from bug 531148 but in this case the assert is actually bogus.  I should probably refactor some of this stuff into a DoAppendFrames that doesn't assert this assertion (because it's false in the recursive call case, as seen here).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Possible fix

This is ugly, but having a DoAppendFrames would involve either putting the "get the next sibling" code into a debug-only block in AppendFrames or something.  That code is needed on both the recursive codepath or the other one.

Alternately, I could make the argument non-debug-only, or I could make the asserts assert only if the first new frame is not the special sibling of aPrevSibling.  Let me know.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 418961 [details] [diff] [review]
Possible fix

I would just make the function always take the aIsRecursiveCall parameter, debug or not.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/8e1185b4a132 with that change.