536903 - [Mac] Need new css for clearListButton

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

I forgot the button - same principle as the pageInfo css (all icons have been removed) in bug 525698.

Comment 1

[Stefan [:stefanh]]

Attachment: New css

I added Markus to the file since I rip most stuff from him.

Comment 2

[[e-mail]]

Comment on attachment 419260 [details] [diff] [review]
New css

>+  background: -moz-linear-gradient(top, #FFF, #ADADAD) repeat-x;
Three nits, two of which you got right later on:
1. repeat-x is unnecessary (makes no sense for a gradient)
2. should be background-image (background is a shortcut for multiple styles)
3. I'd prefer six-digit colour codes i.e. #FFFFFF throughout.

>+  background: #B5B5B5;
Nit: background-color

sr=me with these fixed.

Comment 3

[[e-mail]]

(In reply to comment #2)
>(From update of attachment 419260 [details] [diff] [review])
>>+  background: -moz-linear-gradient(top, #FFF, #ADADAD) repeat-x;
>Three nits, two of which you got right later on:
>1. repeat-x is unnecessary (makes no sense for a gradient)
>2. should be background-image (background is a shortcut for multiple styles)
>3. I'd prefer six-digit colour codes i.e. #FFFFFF throughout.
> 
>>+  background: #B5B5B5;
>Nit: background-color
OK, so the second is supposed to override the first, and just to be difficult, one uses a solid colour and one uses a gradient. In that case, how about:
background-color: #B5B5B5;
background-image: -moz-linear-gradient(top, #FFFFFF, #ADADAD);
...
background-image: none;

Comment 4

[Stefan [:stefanh]]

Landed with suggested changes:
http://hg.mozilla.org/comm-central/rev/a61f577ca2e4

Then I discovered tha I missed one nit, so I landed another changeset:
http://hg.mozilla.org/comm-central/rev/2c8fc8ea5c2f