537183 - /firefox/about/ page and rewrite rule are outdated

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Tony Chung [:tchung]]

Attachment: Unstarred bookmark screenshot

The About Us page (http://www.mozilla.com/en-US/firefox/about/) has been unstarred/unbookmarked, yet it still remains starred in the bookmarks list.

See screenshots

Repro;
1) Using N900, Mozilla/5.0 (X11; U; Linux armv71; en-US; rv:1.9.2b6pre)
Gecko/20091229 Fennec/1.0b6pre
2) goto About Us page (see URL)
3) swipe left, and Unstar / unbookmark the page
4) click the URL to pull up the bookmarks dashboard page
5) Verify the about US page is still starred.

Expected:
- The About Us page gets unstarred after unbookmarking it

Actual:
- About us page on the bookmarks dashboard is still starred

Comment 1

[Tony Chung [:tchung]]

Attachment: Starred bookmark screenshot

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I bet that's because the bookmarks is on "http://www.mozilla.com/en-US/about/" but when going to the page I finished on http://www.mozilla.com/en-US/about/whatismozilla.html

In my case the star in the right sidebar is already unbookmarked

Comment 3

[Aakash Desai [:aakashd]]

Is this still happening to you, Tony?

Comment 4

[Matt Brubeck (:mbrubeck)]

Looks like Vivien is right.  To delete this bookmark you can go to "All Bookmarks" and use the "Manage" button.

Comment 5

[Aakash Desai [:aakashd]]

Uh, that's confusing to the user. We should move this bug over to webpages and try to find a solution there. This bug is not invalid as there is a break in the user experience of going to "About us". 

Alex, where would be an appropriate place to move this bug to?

Comment 6

[Alex Buchanan [:abuchanan]]

A couple things,

1)  There is a website bug.  /{locale}/firefox/about/ is out-dated and should be removed, and the rewrite rule should be changed to point at /about/ instead of /about/whatismozilla.html IMO.  

Pascal, we could move localized /firefox/about/index.html pages to /about/index.html, since it looks like /about/index.html isn't localized yet.  Your call.

2)  The bookmark should point at /about/, not /firefox/about/ since that will always 301.  I've file bug 572056 for this.

Comment 7

[Aakash Desai [:aakashd]]

Thanks for the help, Alex.

Comment 8

[Alex Buchanan [:abuchanan]]

Wilson, could you?

Please remove /firefox/about/index.html

There are localized versions of /firefox/about/index.html.  You can move those to /{locale}/about/index.html

There is a rewrite that points /firefox/about/ to /about/whatismozilla.html.  Please change that to point to /about/.  Also, please make sure that rewrite uses [PT] (pass through) instead of redirecting, so that old bookmarks work correctly.

Comment 9

[Wilson Lee [:kourge]]

In addition to en-US/firefox/about/index.html, ko and pt-BR both have {locale}/firefox/about/index.html. Should those be removed as well?

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

ab-CD/firefox/about/ should be moved to ab-CD/about/, in the case of ko and pt-BR just delete /firefox/about, don't move them to ab-CD/about/

Comment 11

[Wilson Lee [:kourge]]

Committed at r73217.

Comment 12

[Wilson Lee [:kourge]]

Some files were accidentally deleted. Backing out and redoing.

Comment 13

[Wilson Lee [:kourge]]

Okay, fixed at r73221.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

1. http://www-trunk.stage.mozilla.com/en-US/firefox/about/index.html is removed, as per comment 8.
2. However, I thought http://www-trunk.stage.mozilla.com/en-US/firefox/about would redirect to http://www-trunk.stage.mozilla.com/en-US/about?

Does PT not trigger a 302?  When I ran http://www-trunk.stage.mozilla.com/en-US/firefox/about through Live HTTP Headers, I didn't see it redirect anywhere.  (Ditto for https://www-trunk.stage.mozilla.com/fr/firefox/about, etc.)

Comment 15

[Wilson Lee [:kourge]]

No, per comment 8, http://www-trunk.stage.mozilla.com/en-US/firefox/about is rewritten with PT (Pass Through), so it serves identical content as http://www-trunk.stage.mozilla.com/en-US/about but does not redirect to it.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #15)
> No, per comment 8, http://www-trunk.stage.mozilla.com/en-US/firefox/about is
> rewritten with PT (Pass Through), so it serves identical content as
> http://www-trunk.stage.mozilla.com/en-US/about but does not redirect to it.

OK, cool, thanks.  I'll remember that for future PT rewrites.  Removing qawanted keyword.

Comment 17

[Pascal Chevrel:pascalc (PTO until April 26)]

Wilson, can I push your changes to stage/prod?

Comment 18

[Wilson Lee [:kourge]]

AFAICT this can be pushed to prod.

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

on production in r73889

Comment 20

[raymond [:retornam] (inactive)]

verified fixed on production 

http://www.mozilla.com/en-US/about


http://www.mozilla.com/es-CL/about