537526 - clearer talos message for non-zero browser return code error

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I thought crashes during talos runs showed minidumps in the log.  However, this Windows log is reported as a crash, but has no minidump:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262432274.1262432944.2166.gz
WINNT 6.0 mozilla-central talos svg on 2010/01/02 03:37:54  
FAIL: Busted: tsvg_opacity
FAIL: browser crash (code 1)

There have also been some Mac talos runs shown as "terminated", but I'm not sure if those are crashes or something else weird.

Comment 1

[alice nodelman [:alice] [:anode]]

This indicates that the browser closed with a return value other than 0, which talos considers to be a failure.  In this case the value was 1, which is all the information that talos has to go on.

Comment 2

[alice nodelman [:alice] [:anode]]

This is the expected behavior on return codes from the browser other than 0.

Closing.

Comment 3

[alice nodelman [:alice] [:anode]]

Should fix the talos message so that this is less confusing.

Comment 4

[alice nodelman [:alice] [:anode]]

Attachment: [checked in]clearer message for non-zero return code from browser

Comment 5

[alice nodelman [:alice] [:anode]]

Comment on attachment 421155 [details] [diff] [review]
[checked in]clearer message for non-zero return code from browser

/cvsroot/mozilla/testing/performance/talos/bcontroller.py,v  <--  bcontroller.py
new revision: 1.10; previous revision: 1.9
done