537843 - Disable disk cache for fennec 1.0

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

In b5, disk cache was off.  The pref "browser.cache.disk.parent_directory" was set to some non-existent location.  After we enabled the disk cache, page load times significantly increased.  This is most likely caused by the cost of disk writes.  When I disable disk cache, page load times matches that of b5.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

OOC, when and why was it turned on?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> OOC, when and why was it turned on?

We assumed it was always turned on for Maemo. It was working on the N810. We set the cache location using the "browser.cache.disk.parent_directory" pref to a partition with a lot of free space. The N900 uses different folders and we were pointing to a non-existent folder. So we fixed that.

Since we were not explicitly disabling the disk cache, only pointing to a non-existent folder, I assume the thinking is that the folder check in the nsCacheService did _not_ fail:

http://mxr.mozilla.org/mozilla-central/source/netwerk/cache/src/nsCacheService.cpp#423

I was assuming that the check failed and we then reverted to using the profile folder to hold the cache.

Comment 4

[Doug Turner (:dougt)]

fwiw, microb also is not using the disk cache.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

"When I disable disk cache, page load times matches that of b5."

We have Tp numbers?

Comment 6

[Doug Turner (:dougt)]

head-to-head comparisons using a n900 over a half a dozen sites.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 420002 [details] [diff] [review]
patch v.2

Yes, I have seen faster page loads with this setting.

Comment 8

[Doug Turner (:dougt)]

http://hg.mozilla.org/mobile-browser/rev/3877bec117f2

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; Linux armv7l; en-US; rv:1.9.2) Gecko/20100105 Firefox/3.6
Fennec/1.0

and

Mozilla/5.0 (X11; Linux armv6l; en-US; rv:1.9.2) Gecko/20100105 Firefox/3.6
Fennec/1.0