538089 - [AMO] Zeus isn't setting the x-forwarded-for header?

Status: VERIFIED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Wil Clouser [:clouserw]]

I'm not seeing the X-Forwarded-For header on preview or production AMO.  http://knowledgehub.zeus.com/faqs/2007/07/09/passing_client_ip_in_http_headers says it's not on by default but can be flipped with:

http.setHeader("X-Forwarded-For", request.getRemoteIP());

I thought we already had that set, but I guess not?

This is blocking QA. Thanks.

Comment 1

[matthew zeier [:mrz]]

Already had a rule created but it wasn't applied to addons-ssl.  

Have added to both - can you let me know if it's working as expected now?

Comment 2

[Wil Clouser [:clouserw]]

Looks good on preview and production.

On preview it looks like two additional things are getting set:

REDIRECT_is-forwarded  =>  1
is-forwarded  =>  1

I don't care if more stuff is set, but preview and prod should be the same.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/reviews/display/3829:

by stephend (63.245.220.240) on January 6, 2010