Closed Bug 53813 Opened 24 years ago Closed 24 years ago

themes/classic/communicator/communicator.css should not include prefpanels.css

Categories

(SeaMonkey :: Themes, defect, P2)

Product:
SeaMonkey
Component:
Themes
Platform:
PowerPC
Mac System 8.5
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: sfraser_bugs, Assigned: andreww)

References

(
URL
)

Details

(Keywords: classic, Whiteboard: [nsbeta3++][fix ready]) 

prefpanels.css is not present in the mac classic skin, yet communicator.css still 
includes it. This causes the app to stall at startup in Mac.

What I don't understand is why this bug only shows up when *not* using jar files. 
Do missing CSS files not cause stalls when using jars?
Keywords: classic
nsbeta3 keyword. Trivial fix, risks are high (unpredictable behaviour with 
missing CSS files, and this affets the first window the user sees).
Keywords: nsbeta3
Erm, "risks" there is "risks if not fixed"

*** Bug 53812 has been marked as a duplicate of this bug. ***
applying this patch fixes really bad skin switching bugs when switching from 
modern to classic. we need this bug fixed.
Keywords: nsmac1
raising priority as it has broad consequensts for skin switching.
Priority: P3 → P2
Patch:

Index: mozilla/themes/classic/communicator/mac/communicator.css
===================================================================
RCS file: /cvsroot/mozilla/themes/classic/communicator/mac/communicator.css,v
retrieving revision 1.7
diff -r1.7 communicator.css
17,18d16
< @import url(chrome://communicator/skin/prefpanels.css);
< 

Nominating for ++.   Removing this one line from one file must be done and I 
recommend doing this for nsbeta3 because it fixes some really nasty skin 
switching bugs.  Low risk high win.
Assignee: hangas → andreww
Whiteboard: nsbeta3+
Accepting. Working on this today.
Status: NEW → ASSIGNED
I have this ready in my tree .
Whiteboard: nsbeta3+ → [nsbeta3+][fix ready]
We need this on the branch too; it kills mac classic skin otherwise.

nsbeta3++
Whiteboard: [nsbeta3+][fix ready] → [nsbeta3++][fix ready]
ok will check into both locations...
ok now fishing for a reviewer and approver.

fixed branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
work ok on Mac (2000-09-27-11-MN6).
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.