538891 - Overflow at CEnumFormatEtc::Next

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

https://bugzilla.mozilla.org/show_bug.cgi?id=537414#c7

Comment 1

[Jim Mathies [:jimm]]

Comment on attachment 420975 [details] [diff] [review]
Patch

+ PRUint32 count = NS_MIN(static_cast<PRUint32>(aMaxToFetch), left);

Do we need that static cast anymore?

Comment 2

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/f5fca857c581

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 420975 [details] [diff] [review]
Patch

We haven't seen any actual regressions from this yet (it's more of a theoretical bug than anything) but it's an easy fix so we may want to consider taking it on branch.

Comment 4

[Daniel Veditz [:dveditz]]

nominated for older branches because it fixes a regression from bug 533691

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 420975 [details] [diff] [review]
Patch

a1922=beltzner

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Landed on 1.9.2 as http://hg.mozilla.org/releases/mozilla-1.9.2/rev/263ee4ee7da2

Landed on 1.9.1 in the rollup.

Comment 7

[Tracy Walker [:tracy]]

I don't know what to test here. verified per check-in and verification of 533691

Comment 8

[Jim Mathies [:jimm]]

(In reply to comment #7)
> I don't know what to test here. verified per check-in and verification of
> 533691

Nothing really to test, this was just a bug fix patch for some code that landed.