Closed Bug 539034 Opened 15 years ago Closed 14 years ago

Testcase ecam3/Date/e15_9_5_4.as does NOT function correctly.

Categories

(Tamarin Graveyard :: Virtual Machine, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
flash10.1

People

(Reporter: brbaker, Assigned: brbaker)

Details

Attachments

(1 file)

While investigating testcase failures on solaris for bug# 538635 I was looking into this testcase. It appeared that it was actually NEVER running properly. Ever since this testcase was introduced it has been validating that the regexp is throwning an error, which is expected since it does not properly match the date string. 

Tamarin still produces a date string format that matches what netscape/Rhino previously generated "Jan 07 13:40:34 GMT-0800 2002". However netscape/rhino changed this format to "Jan 07 2002 13:40:34 GMT-0800" and the testcase was modified for this new format.

Reverting back the extractTimeString() to its original 2002 version (http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/js/tests/ecma_3/Date&command=DIFF_FRAMESET&root=/cvsroot&file=15.9.5.4.js&rev1=1.1&rev2=1.2) makes the testcase run properly in tamarin.
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Attached patch testcase patchSplinter Review
Previous output for test #3
().toTimeString() = OOPS! FATAL ERROR: no regexp match in extractTimeString() PASSED!

Current, correct output:
(Wed Dec 31 19:00:00 GMT-0500 1969).toTimeString() = 19:00:00 GMT-0500 PASSED!
Attachment #421091 - Flags: review?(cpeyer)
Assignee: nobody → leon.sha
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.1
Assignee: leon.sha → brbaker
Attachment #421091 - Flags: review?(cpeyer) → review+
Comment on attachment 421091 [details] [diff] [review]
testcase patch

Patch pushed:

tr-argo: 3757:fb2a6464082e
tr: 3923:fb2a6464082e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: