539133 - remove broken Opera profile migrator

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Dietrich Ayala (:dietrich)]

From File/Import, the only option available is "cookies".

When importing on "first run", the wizard shows the homepage import option, but only shows a single choice: the Firefox default homepage. Then the next page says migration complete, and the summary shows only cookies as being imported.

Comment 1

[Henri Sivonen (:hsivonen)]

By code inspection, the Opera profile migrator hard-codes Opera 6-specific file names. Chances are that Opera has renamed the files since then.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Does this fix all of the issues on all platforms? I'm pretty tempted to just remove the Opera profile migrator, at least until we can rewrite it in JS and properly test it fully.

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #3)
> Does this fix all of the issues on all platforms? I'm pretty tempted to just
> remove the Opera profile migrator, at least until we can rewrite it in JS
> and properly test it fully.

Yes.  Opera 11 uses same filename on all platform (Windows/MacOSX/Linux).  Current code seems to be for Opera 6 per comment #1.

Also, I agree that we remove opera migration until rewriting new JS based code.  (although we need ini parser for js components...)

Gavin, should I remove this migration?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Yeah, let's just kill it, and file a followup to re-implement if needed.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: fix

kill opera migrator.

Comment 7

[Marco Bonardo [:mak]]

(In reply to Makoto Kato from comment #4)
> (although we need ini parser for js components...)

What's wrong with nsIINIParser?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 578981 [details] [diff] [review]
fix

A couple of things you forgot to remove:
- NS_OPERAPROFILEMIGRATOR_CID #define in nsBrowserCompsCID.h, and a reference to it in nsModule.cpp
- importFromOpera strings in migration.dtd

r=me with those addressed, thanks!

Comment 9

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39f25929ceea

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/39f25929ceea