Closed
Bug 539280
Opened 15 years ago
Closed 15 years ago
[OOPP][Linux] Add support for NPNVnetscapeWindow in NPN_GetValue
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jimm, Assigned: benjamin)
References
Details
Attachments
(1 file)
5.65 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
Spin off of bug 536369. We need to add support for Linux. The values that need to be handed over to the child process are generated here - http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp#2835
Assignee | ||
Comment 1•15 years ago
|
||
Our mochitests use this, blocks on-by-default. I think I have a patch.
Assignee: nobody → benjamin
Blocks: 531142
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #421630 -
Flags: review?(karlt)
Assignee | ||
Updated•15 years ago
|
Summary: Add support for NPNVnetscapeWindow query → [OOPP][Linux] Add support for NPNVnetscapeWindow in NPN_GetValue
Assignee | ||
Comment 3•15 years ago
|
||
With this patch I get the following mochitest errors which may be related: 852 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | p1 plugin width - got 200, expected 300 857 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | p2 plugin width - got 200, expected 300 862 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | p2 plugin width - got 200, expected 300 867 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | p2 plugin width - got 200, expected 300 869 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | Matching regions for 'p2': expected {0,0,200,100}, {0,100,50,200}, {150,100,200,200}, got {0,0,200,50}, {0,50,50,200}, {150,50,200,200} 872 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | p2 plugin width - got 200, expected 300 874 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | Matching regions for 'p2': expected {0,0,200,200}, got {0,0,200,50}, {0,50,50,200}, {150,50,200,200} 877 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | p1 plugin width - got 200, expected 300 879 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | Matching regions for 'p1': expected {0,0,200,200}, got {0,0,200,100} 882 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | p2 plugin width - got 200, expected 300 884 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | Matching regions for 'p2': expected {0,100,200,200}, got {0,0,200,50}, {0,50,50,200}, {150,50,200,200} 885 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping2.xhtml | Matching regions for 'p2': expected {0,0,200,50}, {0,50,50,150}, {150,50,200,150}, {0,150,200,200}, got {0,0,200,50}, {0,50,50,200}, {150,50,200,200} 890 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping_table.xhtml | p1 plugin width - got 200, expected 300 892 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping_table.xhtml | Matching regions for 'p1': expected {0,0,300,100}, got {0,0,200,100} 895 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping_table.xhtml | p2 plugin width - got 200, expected 300 897 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_clipping_table.xhtml | Matching regions for 'p2': expected {0,0,300,100}, got {0,0,200,100} 907 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse down X - got -1, expected 15 908 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse down Y - got -1, expected 18 909 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse move X - got -1, expected 15 910 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse move Y - got -1, expected 38 911 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse up X - got -1, expected 15 912 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | p1 mouse up Y - got -1, expected 28 933 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_position.xhtml | p2 plugin width - got 200, expected 182 934 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_position.xhtml | p2 plugin height - got 200, expected 186 All of these call the .getEdge function of the testplugin, which uses NPNVNetscapeWindow to do part of its computation.
Assignee | ||
Comment 4•15 years ago
|
||
Filed bug 539726 about the test failures (at least test_plugin_position which was the easiest for me to debug, I think the rest are the same underlying issue).
Updated•15 years ago
|
Attachment #421630 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/projects/electrolysis/rev/25d70f95c05f
Assignee | ||
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/784f0004101e
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•