539308 - app update litmus test needs to be updated

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

spinoff of bug 538499 comment #11. Not sure if this is the correct component... it was just the closest I could find.

Some background
Bug 534090 comment #59 and other comments in the bug

Words proposed by ashughes:
Update Preferences
There are three update preferences which are recommended to be set in
about:config prior to starting update testing. These preferences are only
necessary if you are testing for the Update Notification.  They are not
required if you are checking for updates manually via the Help menu.

app.update.idletime
Set this to 1. It controls amount of idle time between update checks and must
be less than app.update.interval.

app.update.interval
Set this to 30. It tells Firefox to check for updates every 30 seconds.

app.update.timer
Set this to 30000.  It tells Firefox to fire a timer every 30 seconds.

To set these preferences, follow the steps below:
1. Type about:config into the location bar and press ENTER
2. When the warning page appears, click on I'll be careful, I promise!
3. In the Filter textbox, type app.update
4. Locate each of the above preferences and double click on them to change
their values

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We do not usually use own bugs for updating or creating litmus tests. Instead we do it on the bug which implemented/fixed a feature/bug.

So for this time lets move it back to the Application Update component and assign it to Al. As he told me he will write such a Litmus test.

Comment 2

[Robert Strong (they/them - no direct email)]

The following should be changed as follows now that bug 540356 is fixed.
app.update.interval
Set this to 60. It tells Firefox to check for updates every 60 seconds.

app.update.timer
Set this to 60000.  It tells Firefox to fire a timer every 60 seconds.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Al, any news here?

Comment 4

[Al Billings [:abillings - ex-MoCo]]

I've updated the 3.0 and 3.5 MU testcases:

https://litmus.mozilla.org/show_test.cgi?id=9820
https://litmus.mozilla.org/show_test.cgi?id=9823

https://litmus.mozilla.org/show_test.cgi?id=8763
https://litmus.mozilla.org/show_test.cgi?id=8761

Comment 5

[Robert Strong (they/them - no direct email)]

Al, tests where you manually select help check for updates do not need to change the time related preferences but they do need to change the channel preference. Also, tests that change these preferences need to tell the person running the test to reset these values.

We now have mochitest chrome tests for those two litmus tests and many other tests on trunk and I am planning on backporting them to 3.6 and possibly 3.5.

I didn't see similar tests for 3.5... do they not exist?

Comment 6

[Al Billings [:abillings - ex-MoCo]]

They shouldn't need to reset these values as I don't expect anyone to be running these in a profile that they will use again. Otherwise, they've just major updated themselves to a test build.

When you say that you don't see similar tests for 3.5, it isn't clear what you are saying to me. Similar to what?

We have many other MU tests for things like extension compatibility and the like. We only have two per branch that deal with the timers.

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to comment #6)
> They shouldn't need to reset these values as I don't expect anyone to be
> running these in a profile that they will use again. Otherwise, they've just
> major updated themselves to a test build.
OK... as long as you are sure people don't use a real profile while testing. If they are they will no longer get updates.

They still don't need to set the timer preferences if they are using help -> check for updates as the tests state. The timer preferences are for the background check.

> When you say that you don't see similar tests for 3.5, it isn't clear what you
> are saying to me. Similar to what?
You provided four links. Two of the four links are for 3.0 and two are for 3.6. Do you not have similar / same tests for 3.5?

Comment 8

[Al Billings [:abillings - ex-MoCo]]

(In reply to comment #7)
>> They still don't need to set the timer preferences if they are using help ->
> check for updates as the tests state. The timer preferences are for the
> background check.

Well, they do for the never test if they want to make sure that it is working.
 
> > When you say that you don't see similar tests for 3.5, it isn't clear what you
> > are saying to me. Similar to what?
> You provided four links. Two of the four links are for 3.0 and two are for 3.6.
> Do you not have similar / same tests for 3.5?

There are no more MUs to 3.5. 3.0 goes to 3.6 and 3.5 goes to 3.6.

In fact, the next 3.0 release (3.0.19) is the planned end of 3.0 and will be the last MU as well. We're end of lifing 3.0.

Comment 9

[Robert Strong (they/them - no direct email)]

Sorry about that and you are correct.

Hopefully we can get rid of all of these tests in the near future now that there are mochitest chrome tests.

Resolving back to fixed

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Rob, given our existent mochitests, do you see any value in having Mozmill tests for testing the background update?

Comment 11

[Robert Strong (they/them - no direct email)]

No