539461 - XPCShell dump warnings in our JS code

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Playing with openkomodo I've seen these warnings in the source code

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 421460 [details] [diff] [review]
Patch

>diff -r 736269688cd5 chrome/content/browser.js

> function importDialog(parent, src, arguments) {

>-  let parent = selectContainer.parentNode;
>+  parent = selectContainer.parentNode;

This means that the passed-in "parent" is ignored. I think it's only used internally, so perhaps we should just remove that argument? Or use a different name for this variable, if that's not feasible.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 421460 [details] [diff] [review]
Patch

rebase and post a new patch

Comment 3

[BMO Automation]

Closing all opened bug in a graveyard component