539585 - warning: format ‘%p’ expects type ‘void*’, but argument [n] has type ‘[class]*’

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: list of these warnings right now

Filing this bug on fixing gcc / g++ build warnings like this one:
{
 mozilla/content/svg/content/src/nsSVGStringProxyValue.cpp:154: warning: format ‘%p’ expects type ‘void*’, but argument 2 has type ‘nsSVGStringProxyValue*’
}

see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26542 for discussion on this warning.

It's easy to fix -- just static_cast the pointer to be a void*, when passing to printf.

Currently we've got 67 warnings of this type.  3 of those are in sqlite3.c, and the rest are in mozilla code. (most in /editor/libeditor/base/*Txn.cpp)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix for /xpcom/ directory

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix for /content/ directory

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix for /editor/ directory

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: fix for /layout/ directory

Comment 5

[Daniel Holbert [:dholbert]]

With the 4 attached patches, we're just left with the 3 of these warnings in sqlite3.c.

Comment 6

[[e-mail]]

Comment on attachment 421540 [details] [diff] [review]
fix for /editor/ directory

>+    printf("%p Undo Insert Element of %p into parent %p at offset %d\n",
>+           static_cast<void*>(this),
>+           static_cast<void*>(mNode.get()),
>+           static_cast<void*>(mParent.get()), mOffset);
Nit: when you need more than two lines to list all the printf parameters, I
think it might make more sense to put them all on separate lines, to reduce
the chance that one subsequently gets overlooked.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 421541 [details] [diff] [review]
fix for /layout/ directory

r=dbaron

I hate this warning.

Comment 8

[Daniel Holbert [:dholbert]]

Attachment: fix for /editor/ directory v2 (r=neil)

(In reply to comment #6)
> Nit: when you need more than two lines to list all the printf parameters, I
> think it might make more sense to put them all on separate lines, to reduce
> the chance that one subsequently gets overlooked.

Agreed - fixed in this version. Carrying forward r+.

(In reply to comment #7)
> I hate this warning.

Yeah, me too.

Comment 9

[Daniel Holbert [:dholbert]]

Landed patches for /content, /editor, and /layout:
http://hg.mozilla.org/mozilla-central/rev/f01750182bfc
http://hg.mozilla.org/mozilla-central/rev/019b7d6e4fc0
http://hg.mozilla.org/mozilla-central/rev/8e0c12450eee

Comment 10

[Daniel Holbert [:dholbert]]

Pushed a fix for a new instance of this in nsTableFrame.cpp:
http://hg.mozilla.org/mozilla-central/rev/8816f2b76e41

Comment 11

[Daniel Holbert [:dholbert]]

Attachment: fix for /testing/ directory

Here's a patch to fix a few instances of this warning in testing/mochitest/ssltunnel/ssltunnel.cpp (introduced with some logging code in changeset b7ee0f1acfef).  This also removes a few tab characters from that file.

Comment 12

[Jeff Walden [:Waldo]]

Comment on attachment 424889 [details] [diff] [review]
fix for /testing/ directory

I echo dbaron.

Comment 13

[Daniel Holbert [:dholbert]]

Landed fix for /testing/: http://hg.mozilla.org/mozilla-central/rev/4ac114ee6247

Comment 14

[Daniel Holbert [:dholbert]]

Landed fix for /xpcom/: http://hg.mozilla.org/mozilla-central/rev/970ed5de45ad

That's all the patches posted here. Resolving as FIXED.