539604 - 'top rated' add-ons are not

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect, P3)

Description

[navigator662003]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729)

I was looking at the list of top-rated Bookmarks, but when I clicked on 'view all top rated' they were not in any kind of order in terms of stars. Some had only two, and some were not even rated yet.

I then checked other categories, and the problem was there as well, e.g. privacy and Security. Apparently the sort routine for this view option is no longer working properly.

Reproducible: Always

Steps to Reproduce:
1.Select 'browse add-ons'
2.Choose a category
3.Look at the sorted list in 'view all top rated'
Actual Results:  
two-star add-on
no stars (not yet rated)
five stars
etc (random ratings)

Expected Results:  
all 5 stars, at least on the first page
then all four stars, all three stars, etc.

nothing special that I know of that would be relevant

Comment 1

[Tyler Downer [He/Him]]

Is this in the addons window, or on addons.mozilla.com? assuming the latter, as you gave alink, so moving there.

Comment 2

[Wil Clouser [:clouserw]]

Attachment: fix

is it just me, or do we seem to have a lot of trouble with those sort options?

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Comment on attachment 421589 [details] [diff] [review]
fix

works as promised. A+++++

Comment 4

[Wil Clouser [:clouserw]]

r59890

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:93 now points to https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:93?sort=averagerating, which is fine.

Comment 6

[Tanay Gavankar [:tgavankar]]

Marking as in-testsuite+, see (r68813)

Comment 7

[Pratibha]

in-litmus+: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=11754