Closed
Bug 539722
Opened 14 years ago
Closed 14 years ago
Port |Bug 515433 - (CSP) Implement core CSP elements| to SeaMonkey
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a1
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
(Keywords: fixed-seamonkey2.0.3)
Attachments
(2 files)
2.25 KB,
patch
|
Callek
:
review+
Callek
:
review+
|
Details | Diff | Splinter Review |
911 bytes,
patch
|
Callek
:
review+
kairo
:
approval-seamonkey2.0.3+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #421648 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #421649 -
Flags: review?(bugspam.Callek)
Attachment #421649 -
Flags: approval-seamonkey2.0.3?
Updated•14 years ago
|
Attachment #421649 -
Flags: approval-seamonkey2.0.3? → approval-seamonkey2.0.3+
Comment 3•14 years ago
|
||
Comment on attachment 421649 [details] [diff] [review] (Bv1-191) Support downgrading [Checkin: Comment 11] I'm not sure this downgrade path is really worth the trouble, but while your here; why not.
Attachment #421649 -
Flags: review?(bugspam.Callek) → review+
Comment 4•14 years ago
|
||
Comment on attachment 421648 [details] [diff] [review] (Av1) Package contentSecurityPolicy.js [Checkin: Comment 10] >+#ifdef MOZILLA_1_9_2_BRANCH >+components/contentSecurityPolicy.js >+#endif > components/crashreporter.xpt > #ifdef MOZILLA_1_9_2_BRANCH > components/crypto-SDR.js > #endif ... > #ifndef MOZILLA_1_9_2_BRANCH >+bin\components\contentSecurityPolicy.js > bin\components\crypto-SDR.js > #endif Nit: keep groupings consistent, preferably one if[n]def. Not ready to land until Bug 515433 does. IFF there is an new iteration there, I want to re-review this (or a new patch) before you push though. [Current at time of this review is v7.5]
Attachment #421648 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #4) > Nit: keep groupings consistent, preferably one if[n]def. I'm rather keeping the list sorted: the if[n]def will be removed after branching...
Whiteboard: [Not ready to land until Bug 515433 does]
Comment 6•14 years ago
|
||
(In reply to comment #5) > (In reply to comment #4) > > Nit: keep groupings consistent, preferably one if[n]def. > > I'm rather keeping the list sorted: the if[n]def will be removed after > branching... You convinced me, nit retracted.
Assignee | ||
Comment 7•14 years ago
|
||
Comment on attachment 421648 [details] [diff] [review] (Av1) Package contentSecurityPolicy.js [Checkin: Comment 10] Per your comment 4: there was a v7.6 version of the Core patch...
Attachment #421648 -
Flags: review?(bugspam.Callek)
Comment 8•14 years ago
|
||
Comment on attachment 421648 [details] [diff] [review] (Av1) Package contentSecurityPolicy.js [Checkin: Comment 10] no change to this patch needed, thanks.
Attachment #421648 -
Flags: review?(bugspam.Callek) → review+
Comment 9•14 years ago
|
||
> [Not ready to land until Bug 515433 does]
The relevant build config change seems to have landed.
Assignee | ||
Comment 10•14 years ago
|
||
Comment on attachment 421648 [details] [diff] [review] (Av1) Package contentSecurityPolicy.js [Checkin: Comment 10] http://hg.mozilla.org/comm-central/rev/8b266f10c466
Attachment #421648 -
Attachment description: (Av1) Package contentSecurityPolicy.js → (Av1) Package contentSecurityPolicy.js
[Checkin: Comment 10]
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [Not ready to land until Bug 515433 does]
Assignee | ||
Comment 11•14 years ago
|
||
Comment on attachment 421649 [details] [diff] [review] (Bv1-191) Support downgrading [Checkin: Comment 11] http://hg.mozilla.org/releases/comm-1.9.1/rev/ca986f28d2c1
Attachment #421649 -
Attachment description: (Bv1-191) Support downgrading → (Bv1-191) Support downgrading
[Checkin: Comment 11]
Assignee | ||
Updated•14 years ago
|
Keywords: fixed-seamonkey2.0.3
You need to log in
before you can comment on or make changes to this bug.
Description
•