Closed Bug 539824 Opened 15 years ago Closed 14 years ago

Use the same is-callable test in js_obj_define{G,S}etter and PropertyDescriptor::initialize

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 547046

People

(Reporter: Waldo, Assigned: Waldo)

Details

The former use JS_TypeOfValue == JSTYPE_FUNCTION.  The latter uses js_IsCallable.  Which implementation is "right"?

In any case, having two separate ways (one more generic than the other) to do the same thing is a bad idea.  js_IsCallable should include whatever the desired code is, and it should be used universally.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.