540108 - Add a src parameter for add-ons From Similar Collections

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Jeff Balogh (:jbalogh)]

fligtar: What do I need to do besides adding a src parameter?

Comment 1

[Justin Scott [:fligtar]]

It needs to be in the download_sources table and we need to add a description to the stats component.

Please rename it from reco to something less likely to be confused with the recommended list, like "similar"

for stats dashboard:

From Similar Add-ons
Downloads from the "Often Used With" section of another add-on's display page

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to comment #1)
> Please rename it from reco to something less likely to be confused with the
> recommended list, like "similar"

reco is the src param for addons recommended from "Often Used With".  If you don't like that one, it's a different bug.

Comment 3

[Jeff Balogh (:jbalogh)]

To be clear:

This bug is about the add-on recommendations in "From Similar Collections" on collection detail pages, which does not have a src param yet.

The add-on recommendations from the "Often Used With" section on add-on detail pages has a src param called "reco".  If that makes fligtar unhappy, he will open a new bug.

Comment 4

[Justin Scott [:fligtar]]

Okay, then make the src=similarcollections and details:

From Similar Collections
Downloads through the "From Similar Collections" section on collection pages

Make sure to add it to the download_sources table as well. I'll file a separate bug for fixing the other src.

Comment 5

[Justin Scott [:fligtar]]

Actually, I thought of better wording:

From Similar Collections
When this add-on is suggested on a collection's page that it is not actually a part of, downloads from that link are counted here.

Comment 6

[Jeff Balogh (:jbalogh)]

Fixed with bug 540950 in r60948.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collection/travel; the links are like so: https://preview.addons.mozilla.org/en-US/firefox/addon/138?src=similarcollections

In-litmus+: https://litmus.mozilla.org/show_test.cgi?id=9870

Comment 8

[Tanay Gavankar [:tgavankar]]

in-testsuite+: (r69213)