Open Bug 540222 Opened 15 years ago Updated 2 years ago

--disable-xul means NS_STYLE_DISPLAY_INLINE_GRID is undefined, compile failure

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

People

(Reporter: WeirdAl, Unassigned)

Details

Attachments

(1 file)

patch, v1
1.05 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached patch patch, v1 — — Splinter Review 
      No description provided.
Attachment #422041 - Attachment is patch: true
Attachment #422041 - Attachment mime type: application/octet-stream → text/plain
Attachment #422041 - Flags: superreview?(bzbarsky)
Attachment #422041 - Flags: review?(bzbarsky)
It looks like this makes the checks for NS_STYLE_DISPLAY_INLINE_{GRID,STACK} ifdef-ed out, but not the one for ...INLINE_BOX, which the bug's summary suggests is the problem.
Whoops - I'm pretty sure the patch is right and the summary is wrong. :(
Summary: --disable-xul means NS_STYLE_DISPLAY_INLINE_BOX is undefined, compile failure → --disable-xul means NS_STYLE_DISPLAY_INLINE_GRID is undefined, compile failure
Attachment #422041 - Flags: superreview?(bzbarsky)
Attachment #422041 - Flags: review?(bzbarsky)
Attachment #422041 - Flags: review+
Comment on attachment 422041 [details] [diff] [review]
patch, v1

r=bzbarsky (no sr needed here).
Can this still be checked in?
I don't think we support --disable-xul anymore, but "#ifdef MOZ_XUL" might be good
anyway for documentation.  I would rather see that we try to *remove* XUL though,
than maintaining it.
Component: Layout → XUL
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: