54090 - Options|Rewrap doesn't work on the Mac

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Ninoschka Baca]

Build 2000-09-21-04M18: Mac 9.04

Overview: In plain text mode, select a message, select the Reply button, select
Options|Rewrap and it just hangs on the Mac.

On NT4 and Linux it behaves differently but these problems are reported in bug#
51799.

Comment 1

[Ninoschka Baca]

Setting to Major because the application should not hang/crash.

Comment 2

[Jean-Francois Ducarroz]

I can reproduce this problem with the last build. Kind of annoying...

Comment 3

[scottputterman]

changing milestone to unknown.  It will get changed back when we figure out what
milestone to put this bug in.

Comment 4

[Jean-Francois Ducarroz]

I don't see any hang or crash. However, rewrap doesn't seem to do anything on Mac!!!

Comment 5

[Jean-Francois Ducarroz]

reassign to akkana...

Comment 6

[Akkana Peck]

It doesn't do anything for you?  Did you have quoted text selected?

It does rewrap for me, but it has a bug: it keeps the quote characters ("> ")
even after wrapping, so
> one
> two
will rewrap to 
> one > two

I'll look at it.

Comment 7

[Akkana Peck]

Oh, I see.  Rewrap first converts the selection (or the whole document, if
selection is collapsed) to a string, then rewraps the string.  But it doesn't
specify newline type in the output flags used to generate the string, and
default is platform specific.  But then the rewrapping code was looking for dom
newlines rather than all newline formats.

I have a patch which explicitly specifies LF/DOM line breaks.  In addition, I've
added a check to make sure (in debug builds only) that there aren't any CRs
there (because if there are, there's a bug somewhere else in the code and I need
to know about it); and to default the wrap column to 72 if none is specified
(because rewrapping to no wrap column makes no sense, and it's confusing to have
it do nothing); and, finally, to set the RespectNewlines flag to true instead of
false when Rewrap is called, because that seems more reasonable.

This needs testing on a mac!  My mac can't build right now, so I'll need some
help from a mac person to test this.  Maybe J-F, since it affects mail compose
most, or maybe Simon, since he'll probably eventually be the one I'll ask for an
sr on this code.  It can be tested either in the plaintext editor (where rewrap
is in the debug menu) or in plaintext mail compose.

Comment 8

[Akkana Peck]

Attachment: Fix

Comment 9

[Kathleen :Brade]

r=brade

Comment 10

[Akkana Peck]

Kathy noticed that in nsInternetCiter.cpp the PR_Unichar should be PRUnichar,
and her review was naturally contingent upon that fix change.

Simon, when you get a chance, could you sr this bug?  Thanks!

Comment 11

[Akkana Peck]

Passing to Kathy and cc'ing Kin.  Kin sr'ed this, and I was hoping to check it
in today before I left, but the tree is closed.  Hope one of you can check it in
for me.  Thanks!

Comment 12

[Kathleen :Brade]

fix checked in

Comment 13

[Ninoschka Baca]

Build 2001-05-17-04: Mac 9.04
Verified Fixed. I replied to a message, type some text and selected 
Options|Rewrap and it does appear to allign the text better.