541017 - e10s HTTP: Create common AddHostHeader function

Status: RESOLVED WONTFIX

(Core :: Networking: HTTP, defect)

Description

[Jason Duell]

Right now we've got some logic in HttpChannelChild::Init to set the Host header (it's currently commented out) that's directly lifted from nsHttpChannel.  We should factor this out into a common function that both HttpChannelChild and nsHttpChannel can call.

Comment 1

[Bjarne (:bjarne)]

I'll grab this one...  any preferred ways to share the code? Static method? Macro? Util-class? (I guess inheritance is not an option?)

Comment 2

[Bjarne (:bjarne)]

Releasing this bug as requested in email.

Comment 3

[Bjarne (:bjarne)]

Attachment: Suggestion - not tested

This is a suggested way to do this. Feel free to grab it and modify.

Comment 4

[Jae-Seong Lee-Russo]

I will continue working based on the suggestion.

Comment 5

[Bjarne (:bjarne)]

(In reply to comment #4)
> I will continue working based on the suggestion.

You might want to double-check with Jason, Honza or others that this does not break other design-decisions in Electrolysis.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

bug 445168 refactors this in a different way, perhaps that's good enough.

Comment 7

[Bjarne (:bjarne)]

Yes Jae, you should really check with the guys driving the e10s-work whether there are any established best-practices or design patterns for such code-sharing (which I suspect will occur frequently). Using static methods may be safer since you don't risk unintentional shared state between the two subclasses. Check with Jason.

Comment 8

[Jae-Seong Lee-Russo]

Fixed by bug 445168.

Comment 9

[Jason Duell]

Actually this isn't fixed:  we'd still need to call the function biesi created.

But I've decided we should simply share a common Init() class between nsHttpChannel and HttpChannelChild, so that makes this bug moot.

Jae or Bjarne: perhaps one of you could grab Bug 546581?

Comment 10

[Bjarne (:bjarne)]

Attachment: Proposed HttpChannelBase.cpp

Comment 11

[Bjarne (:bjarne)]

Attachment: Proposed HttpChannelBase.h

Attached the proposed implementation of the common base-class. Can be used together with the patch as a start for bug #546581