541631 - Dehydra copyright notice is obviously wrong

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Mike Hommey [:glandium]]

The only copyright notice is found in README, and it says:
Copyright (C) 1983 Mozilla Corporation

Really ? 1983 ?

Comment 1

[Jo Hermans]

What version is this ? The one from Mozilla (NOT from your linux distribution !) only says :

For information about installing, running and configuring Firefox
including a list of known issues and troubleshooting information,
refer to: http://getfirefox.com/releases/

Comment 2

[Mike Hommey [:glandium]]

Let's make the subject more explicit, then.

Comment 3

[martin.feger]

Let's make it easy to find what you're talking about:

http://hg.mozilla.org/rewriting-and-analysis/dehydra/annotate/d039748e7775/README

Comment 4

[Mike Hommey [:glandium]]

I could write a patch, but I'd need the proper copyright information for that... Taras ?

Comment 5

[(dormant account)]

(In reply to comment #4)
> I could write a patch, but I'd need the proper copyright information for
> that... Taras ?

It should be 2007-2008. A patch would be appreciated.

Comment 6

[Mike Hommey [:glandium]]

Should that be copyrighted to MoCo or yourself ? While at it, should I add the GPL boilerplate in every file (or at least *.{c,h,js}) ?

Comment 7

[(dormant account)]

(In reply to comment #6)
> Should that be copyrighted to MoCo or yourself ? While at it, should I add the
> GPL boilerplate in every file (or at least *.{c,h,js}) ?

MoCo; should add these to every file.

Comment 8

[Brendan Eich [:brendan]]

Copyright should cite "The Mozilla Foundation", per Gerv.

/be

Comment 9

[Mike Hommey [:glandium]]

Attachment: Patch

This adds a GPL boilerplate in any file that didn't already have licensing information. FWIW, libs/unstable/BigInt.js already had a GPL header, and a copyright to Masanao Izumo <[e-mail]>. I do hope none of the other files were taken from somewhere else, while lacking copyright information...

Note I haven't touched to the files in test/, I wasn't sure what to do with these.

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 437251 [details] [diff] [review]
Patch

Gerv should probably review this, I guess.

Comment 11

[Gervase Markham [:gerv]]

Comment on attachment 437251 [details] [diff] [review]
Patch

This stuff is closely tied to GCC, which is also GPLv2+, right? If so, r=gerv.

Gerv

Comment 12

[(dormant account)]

Comment on attachment 437251 [details] [diff] [review]
Patch

Why is the copyright date 2007-2008?

Comment 13

[Mike Hommey [:glandium]]

(In reply to comment #12)
> (From update of attachment 437251 [details] [diff] [review])
> Why is the copyright date 2007-2008?

Hum... per comment 5 ?

Comment 14

[(dormant account)]

(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 437251 [details] [diff] [review] [details])
> > Why is the copyright date 2007-2008?
> 
> Hum... per comment 5 ?

I must've been living in the past. I'll r+ a -2010 patch. Do you have checkin rights?

Comment 15

[Mike Hommey [:glandium]]

Attachment: Patch v2

Same, with -2010. (No, I don't have checkin rights (yet))

Comment 16

[(dormant account)]

Comment on attachment 437347 [details] [diff] [review]
Patch v2

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/2cf5dafd16c5

Thanks!

Comment 17

[Mike Hommey [:glandium]]

Attachment: Brown paper bag fix

Necessary (brown paper bag) fix for Makefile.in breakage

Comment 18

[(dormant account)]

Comment on attachment 437534 [details] [diff] [review]
Brown paper bag fix

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/84fb95342c89