542026 - sydney_audio_mac.c bustage on 1.9.1 branch

Status: VERIFIED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Josh Aas]

/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c: In function ‘sa_stream_open’:
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:182: error: ‘ComponentDescription’ undeclared (first use in this function)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:182: error: (Each undeclared identifier is reported only once
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:182: error: for each function it appears in.)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:182: error: expected ‘;’ before ‘desc’
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:183: error: ‘desc’ undeclared (first use in this function)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:189: error: ‘Component’ undeclared (first use in this function)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:189: error: expected ‘;’ before ‘comp’
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:190: error: ‘comp’ undeclared (first use in this function)
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:194: warning: implicit declaration of function ‘OpenAComponent’
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c: In function ‘sa_stream_destroy’:
/Users/josh/src/mozilla/ff_191_debug_32/media/libsydneyaudio/src/sydney_audio_mac.c:283: warning: implicit declaration of function ‘CloseComponent’

Comment 1

[Josh Aas]

Attachment: fix v1.0

Comment 2

[cajbir (:cajbir)]

Comment on attachment 423377 [details] [diff] [review]
fix v1.0

Please add to README_MOZILLA with the details of this bug, and include a patch file that can be applied in update.sh.

For the review use Matthew Gregan ([e-mail]) - he's the maintainer of the libsydneyaudio library now (If I understood FOMS correctly).

Since this fix is already in trunk maybe it's a matter of copying the trunk changes?

Comment 3

[Matthew Gregan [:kinetik]]

Given this is already on trunk, I'm fine with it as long as it's applied the same way it is on trunk (with the patch and readme updates doublec mentioned).

Comment 4

[Matthew Gregan [:kinetik]]

Presumably we don't need this.

Comment 5

[u279076]

I assume from comment 4 that you mean "this isn't a bug on the branches" -- marking verified.  If this IS a bug on the branches which will not be addressed, this should probably be WONTFIX instead.