54258 - need to call LoadAccounts() at the start of CreateIdentity()

Status: RESOLVED INCOMPLETE

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[(not reading, please use [e-mail] instead)]

just like in bugscape bug #2203, we should put a call to LoadAccounts() at the
start of CreateIdentity()

#2203 was caused by activation.js calling CreateIncomingServer() before the
accounts were loaded. the fix was to put a safe call at the start of
CreateIncomingServer()

Comment 1

[(not reading, please use [e-mail] instead)]

Here's a patch:

Index: src/nsMsgAccountManager.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/base/src/nsMsgAccountManager.cpp,v
retrieving revision 1.199.4.1
diff -p -r1.199.4.1 nsMsgAccountManager.cpp
*** nsMsgAccountManager.cpp     2000/09/26 22:37:13     1.199.4.1
--- nsMsgAccountManager.cpp     2000/09/26 23:17:51
*************** nsMsgAccountManager::CreateIdentity(nsIM
*** 288,293 ****
--- 288,296 ----
    
    nsresult rv;
  
+   rv = LoadAccounts();
+   if (NS_FAILED(rv)) return rv;
+ 
    nsCAutoString key;
    getUniqueKey(ID_PREFIX, &m_identities, key);
  

Comment 2

[Alec Flett]

r=alecf

Actually, while you're there do you want to make that an NS_ENSURE_SUCCESS(rv,
rv)? (I know the other locations don't have that, but we might as well start
now.

Comment 3

[(not reading, please use [e-mail] instead)]

yes, I'll use that macro when I check in the fix.

Comment 4

[Håkan Waara]

Seth, nothing except for a sr= is hindering you from checkin this in soon after
the trunk opens again!  :)

Comment 5

[timeless]

Attachment: per alecf

Comment 6

[timeless]

Comment on attachment 107025 [details] [diff] [review]
per alecf

by the time you get to this i should be gone for thanksgiving so i'd request
that this bug be resolved (wont, works, fixed) w/o me. anyone can do the
checkin.

Comment 7

[(not reading, please use [e-mail] instead)]

I'm going to remove the review requests, until I hear back from timeless about a
few things.

I'm suprised to see activity on this old (9-26-2000) bug.

I'd have to remember why we need it, and make sure that it is still the right thing.

I think the reason I never checked in was I never finished thinking about it, or
finished testing it.

switching to NS_ENSURE_SUCCESS(rv,rv); in all cases might not be the right thing
either, as we might expect failure in those cases.  

I just don't know.

timeless, how did you test this patch?  what made you sure that it was still the
right thing?

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 107025 [details] [diff] [review]
per alecf

removing requests until it's clear that this wasn't a patch for patch sake.

Comment 9

[timeless]

it was a patch for a patch's sake. if the bug isn't valid then please close it.

Comment 10

[(not reading, please use [e-mail] instead)]

> it was a patch for a patch's sake. 

ok, thanks for coming clean.

> if the bug isn't valid then please close it.

I bet the bug is still valid.  

but we should double check, re-test, and make sure before creating (and landing)
a patch.

there's plenty of "reminder" bugs like this in bugzilla (that I log on myself)
that shouldn't be closed.

it's better than a "XXX todo" in the code. (which I also do.)

Comment 11

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 12

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 13

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 14

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 15

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420

Comment 16

[Karsten Düsterloh]

Too old, too unclear, and incomplete.

Comment 17

[Nagy Mária]

[Tracking Requested - why for this release]: