542582 - pymake should support -s

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Shawn Wilsher :sdwilsh]

I don't need to see most of the output, and I used to always use make -s.  It'd be really useful to have a -s option in pymake too.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: unfinished patch

So here's an unfinished patch; the main reason is that in process.py, I couldn't figure out how to pass the config/options down to there so that I can do the right thing in _docall.  Right now it just hardcodes to never echo the command, and -s suppresses the directory enter/exit bits.

Comment 2

[Mitchell Field [:Mitch]]

Attachment: WIP

I have no idea if this is the right approach or behaviour. It is what it is.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 462122 [details] [diff] [review]
WIP

>diff --git a/pymake/command.py b/pymake/command.py
>-                                          targets=self.targets, keepgoing=self.options.keepgoing)
>+                                          targets=self.targets, keepgoing=self.options.keepgoing, silent=self.options.silent)
The style here is ... interesting

Does make -s suppress just the echoing or the actual compiler output?

Comment 4

[Mitchell Field [:Mitch]]

Attachment: Patch v1.1

This patch makes it so the "-s" option suppresses command echoing.

Comment 5

[Mitchell Field [:Mitch]]

http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/7372f485a5ca

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

m-c will pick it up the next time we update.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Which just happened.

Comment 8

[Mitchell Field [:Mitch]]

The latest snapshot was backed out a while ago, so I pushed this singly.

http://hg.mozilla.org/mozilla-central/rev/232553f741a0