542958 - fine-tune size & look of of dl_open and dl_reveal icons

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: new dl_open icon

Per bug 384725 comment 30 (smokey & me in agreement)

I reduced the height of the icon by slicing one pixel out of the bottom third part. This brings it in line with the height of the round icons.

Screenshots in context:
http://dev.l-c-n.com/camino/downloads_window/downloads_v2-small.png
http://dev.l-c-n.com/camino/downloads_window/downloads_v2-large.png

Of course, the difference in height with the dl_reveal icon is now more visible, especially the 32x32 one.
zoomed (Pixie with grid):
http://dev.l-c-n.com/camino/downloads_window/downloads-v2-zoom.png

Comment 1

[Samuel Sidler (:ss)]

Comment on attachment 424192 [details]
new dl_open icon

This seems fine to me.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 424192 [details]
new dl_open icon

The 32px size looks fine.  The 24px size, though, looks too small optically; not sure whether the top pixel of the arrow is not as dark, or the fact it's a single pixel vs. 2 pixels in the large one, or what.

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> (From update of attachment 424192 [details])
> The 32px size looks fine.  The 24px size, though, looks too small optically;
> not sure whether the top pixel of the arrow is not as dark, or the fact it's a
> single pixel vs. 2 pixels in the large one, or what.

Mostly the latter, I think. But I don't see that on 10.6. I made a second version of the icon, with a much darker top-pixel. I'll have a look tomorrow on 10.5.
A bunch of screenshots, various states:
http://dev.l-c-n.com/camino/downloads_window/screenshots2/
('-or' is the existing icon, '-v1' is the one attached above, '-v2' has a darker top pixel)
The edited icon:
http://dev.l-c-n.com/camino/downloads_window/dl_open_v1.1.tiff.zip

Comment 4

[philippe (part-time)]

Attachment: dl_open v3

On 10.5, the small icon looks visually slightly smaller, depending on how I look at it, or the contrast settings of the monitor.  Here is another attempt.

(screenshots on 10.6)
http://dev.l-c-n.com/camino/downloads_window/screenshots3/

Comment 5

[philippe (part-time)]

some polish for the dl_reveal icon:
Type: 1 is basically the same as the existing one, with some fine tuning of height, particularly the size of the Finder window. I made the magnifier slightly lighter.
Type 2: alternative using a smaller, wider Finder window behind the magnifier

Some screenshots in context (using the dl_open mentioned in comment 3):
http://dev.l-c-n.com/camino/downloads_window/screenshots4/
both icons are available in the same folder

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #5)
> some polish for the dl_reveal icon:
> Type: 1 is basically the same as the existing one, with some fine tuning of
> height, particularly the size of the Finder window. I made the magnifier
> slightly lighter.

I like the darker handle of the current icon, because it helps keep the handle from getting lost in the window (especially at the smaller size).

> Type 2: alternative using a smaller, wider Finder window behind the magnifier

This window looks too squat.  I would like to see if the handle could get more "clearance" below the bottom of the window, though, so maybe a middle-sized window?

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 424965 [details]
dl_open v3

Yeah, I like this one :-)

(Fixing reveal to line up properly on the top--like it does in T1--helps a lot, too, oddly enough.)

Sorry it's taken me so long to get back to all of these.

Comment 8

[philippe (part-time)]

Attachment: dl_reveal v4 (T3)

dl_reveal v4 (T3).

A slightly taller window than T2, with a darker handle.

Screenshots in context
(24x24px)
http://dev.l-c-n.com/camino/downloads_window/reveal-T3b-s.png
(32x32px)
http://dev.l-c-n.com/camino/downloads_window/reveal-T3b.png

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 434224 [details]
dl_reveal v4 (T3)

This looks like a good middle ground, too :-)

Comment 10

[Stuart Morgan]

Comment on attachment 434224 [details]
dl_reveal v4 (T3)

sr=smorgan

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk and the test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/ea57f2739f36

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/c59530235f44