543061 - Serialize nsID

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

It would be nice to serialize nsID.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Just to make the rationale for doing this slightly more clear, in Bug 441197 we're going to need to pass a nsID to child processes so that their audio gets combined with the parent process's in the Vista audio system.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 424275 [details] [diff] [review]
Patch

>diff --git a/ipc/glue/IPCMessageUtils.h b/ipc/glue/IPCMessageUtils.h
>--- a/ipc/glue/IPCMessageUtils.h
>+++ b/ipc/glue/IPCMessageUtils.h
>@@ -39,16 +39,17 @@
>+template<>
>+struct ParamTraits<nsID>
>+{
>+  typedef nsID paramType;
>+
>+  static void Write(Message* aMsg, const paramType& aParam)
>+  {
>+    WriteParam(aMsg, aParam.m0);
>+    WriteParam(aMsg, aParam.m1);
>+    WriteParam(aMsg, aParam.m2);
>+    for (int i = 0; i < 8; i++) {
>+      WriteParam(aMsg, aParam.m3[i]);
>+    }
>+  }
>+

Nit: |i < NS_ARRAY_LENGTH(aParam.m3)|.

>+  static bool Read(const Message* aMsg, void** aIter, paramType* aResult)
>+  {
>+    if(!ReadParam(aMsg, aIter, &(aResult->m0)) ||
>+       !ReadParam(aMsg, aIter, &(aResult->m1)) ||
>+       !ReadParam(aMsg, aIter, &(aResult->m2)))
>+      return false;
>+
>+    for (int i = 0; i < 8; i++)
>+      if (!ReadParam(aMsg, aIter, &(aResult->m3[i])))
>+        return false;
>+
>+    return true;
>+  }
>+

|i < NS_ARRAY_LENGTH(aResult->m3)|.

>+  static void Log(const paramType& aParam, std::wstring* aLog)
>+  {
>+    aLog->append(L"{");
>+    aLog->append(StringPrintf(L"%8.8X-%4.4X-%4.4X-",
>+                              aParam.m0,
>+                              aParam.m1,
>+                              aParam.m2));
>+    for (int i = 0; i < 8; i++)
>+      aLog->append(StringPrintf(L"%2.2X", aParam.m3[i]));
>+    aLog->append(L"}");
>+  }
>+};
>+

Also here.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 424275 [details] [diff] [review]
Patch

Yeah, r+ with cjones' comments addressed.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch w/nits

w/nits

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Unbitrotting and carrying review forward.  I've got a patch for the bug I wrote this for so I'll probably check this in fairly soon.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/projects/build-system/rev/87c28ff05bad

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/87c28ff05bad