Closed Bug 543332 Opened 14 years ago Closed 14 years ago

Update Help on Popup Windows preferences

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a1

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

(Keywords: fixed-seamonkey2.0.4)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
While looking at bug 459578 I discovered that Help has not been updated for some of the latest changes to the Popup Windows preferences pane and the dialog that can be opened from there. Part of the changes were made in bug 441403.

@IanN: Bug 441403 comment 0, last sentence. ;-)
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #424486 - Attachment is patch: true
Attachment #424486 - Attachment mime type: application/octet-stream → text/plain
Attachment #424486 - Flags: review?(iann_bugzilla)
Comment on attachment 424486 [details] [diff] [review]
patch

>+++ b/suite/locales/en-US/chrome/common/help/cs_priv_prefs_popup.xhtml
>   <li><strong>Play a sound</strong>: If you want a sound to play each time
>-    the browser blocks a popup, select this option and type the location of the
>-    sound file.
>+    the browser blocks a popup, select this option and choose System beep
>+    or Custom sound file. For the latter you can either type the location of
>+    the sound file or browse for it.
As far as I am aware, you can only browse not type the location in the new pref window.
>     <ul>
>-      <li><strong>Select</strong>: Click this to choose a sound file instead of
>+      <li><strong>Browse</strong>: Click this to choose a sound file instead of
>         typing its location in the field.</li>
This needs correcting too.
Attachment #424486 - Flags: review?(iann_bugzilla) → review-
Attachment #424486 - Attachment is obsolete: true
Attachment #424668 - Flags: review?(iann_bugzilla)
Attachment #424668 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 424668 [details] [diff] [review]
patch v1a [Checkin: comments 3 + 5]

http://hg.mozilla.org/comm-central/rev/192025e17ba3
Attachment #424668 - Attachment description: patch v1a → patch v1a [Checkin: comment 3]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Comment on attachment 424668 [details] [diff] [review]
patch v1a [Checkin: comments 3 + 5]

Requesting branch approval.

[KaiRo]	InvisibleSmiley: help changes are allowed, as long as the list of the help files stays the same
Attachment #424668 - Flags: approval-seamonkey2.0.4?
Blocks: 423281
Attachment #424668 - Flags: approval-seamonkey2.0.4? → approval-seamonkey2.0.4+
Comment on attachment 424668 [details] [diff] [review]
patch v1a [Checkin: comments 3 + 5]

http://hg.mozilla.org/releases/comm-1.9.1/rev/167ea8785ebb
Attachment #424668 - Attachment description: patch v1a [Checkin: comment 3] → patch v1a [Checkin: comments 3 + 5]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: