Closed Bug 543554 Opened 14 years ago Closed 12 years ago

[Autoconfiguration] Add sympatico.ca domains

Categories

(Webtools :: ISPDB Server, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rolandtanglao, Assigned: unicorn.consulting)

References

()

Details

(Whiteboard: [gs])

Attachments

(1 file, 2 obsolete files)

Attachment #424656 - Attachment is patch: true
Attachment #424656 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 424656 [details] [diff] [review]
Diff for XML file sympatico.ca 

>Index: sympatico.ca
>@@ -0,0 +1,29 @@
>+<clientConfig>
>+    <emailProvider id="sympatico.ca">
>+      <domain>sympatico.ca/domain>
The previous line should have a "<" before the "/domain>".

And I don't have an account to test it with, so could you make sure that those settings work, Roland?

Aside from that, it passes all the sanity checks, and seems secure, so I'll give it the first r+.

Later,
Blake.
Attachment #424656 - Flags: review?(bwinton) → review+
This is my first try at this. I hope I have a vague idea how it works
Assignee: nobody → unicorn.consulting
Attachment #424656 - Attachment is obsolete: true
Attachment #565909 - Flags: review?(sancus)
(In reply to Matt from comment #2)
> Created attachment 565909 [details] [diff] [review] [diff] [details] [review]
> added the < requested long in the past
> 
> This is my first try at this. I hope I have a vague idea how it works

Drive by comment, I don't see any url with documentation - but probably sympatico doesn't have one.
(In reply to Ludovic Hirlimann [:Usul] from comment #3)
>
> Drive by comment, I don't see any url with documentation - but probably
> sympatico doesn't have one.

http://internet.bell.ca/index.cfm?method=content.view&category_id=585&content_id=12767

Is that supposed to go in bug URL, or here
In the file.
Attached patch New patchSplinter Review
After fumbling around on live mozillamessageing.com I think I have figured out the correct format to include the documentation URL.
Attachment #565909 - Attachment is obsolete: true
Attachment #586937 - Flags: review?(gozer)
Attachment #565909 - Flags: review?(sancus)
Comment on attachment 586937 [details] [diff] [review]
New patch

Looks good and verified.
Attachment #586937 - Flags: review?(gozer) → review+
Attachment #586937 - Flags: review?(sancus)
yeah it looks good Matt, thanks! note that i don't have sympatico and haven't been able to test this. any canadians out there who have sympatico who want to verify this config is correct?
Comment on attachment 586937 [details] [diff] [review]
New patch

& is an invalid character in XML and it should be &amp;

Fixed and committed in r100051 & r100053
Attachment #586937 - Flags: review?(sancus) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: ispdb → ISPDB Server
Product: Mozilla Messaging → Webtools
You need to log in before you can comment on or make changes to this bug.