Closed Bug 543998 Opened 14 years ago Closed 14 years ago

add an android builder to buildbot

Categories

(Tamarin Graveyard :: Build Config, defect)

Product:
Tamarin Graveyard
Component:
Build Config
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: dschaffe, Assigned: dschaffe)

References

Details

Attachments

(4 files, 1 obsolete file)

updated android buildbot patch
42.86 KB, patch
brbaker
: review+
Details | Diff | Splinter Review
patch
27.69 KB, patch
brbaker
: review+
Details | Diff | Splinter Review
actual patch
29.91 KB, patch
Details | Diff | Splinter Review
patch for build-release-android-shell.sh
443 bytes, patch
brbaker
: review-
Details | Diff | Splinter Review 
we'll add a mac compiling the android shell first.  android platform build support was submitted in bug 543512.
Attached patch android compile buildbot patch (obsolete) — — Splinter Review 
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED

        Attachment #424994 -
        Flags: review?(brbaker)

    
    

    
  


  
updated patch after testing on local buildbot.  also added base smoke and test phases for android.

        Attachment #424994 -
        Attachment is obsolete: true

        Attachment #425079 -
        Flags: review?(brbaker)

        Attachment #424994 -
        Flags: review?(brbaker)

    
    

    
  
Comment on attachment 425079 [details] [diff] [review]
updated android buildbot patch

Pushed buildbot configuration, with a bunch of tweaks as TR changeset 3740:3a3915d9fc4e

Pushed buildslave scripts as:
TR-argo: 3658:326014d14403
TR: 3738:326014d14403

        Attachment #425079 -
        Flags: review?(brbaker) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
    

    
  
marking verified.  buildbot mostly worked.
Status: RESOLVED → VERIFIED

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
patch to add smoke and test phase for android

        Attachment #428806 -
        Flags: review?(brbaker)

    
    

    
  
Comment on attachment 428806 [details] [diff] [review]
patch

r+ with comments addressed

caveat: I did not try and run the scripts as I am not setup to run them

- should workdir="../repo/build/buildbot/slaves/scripts"? 
- please rename the /AcceptanceTest/ buildsteps to match the others /Testsuite_Release/
- in run-acceptancetests-android.sh (and in smoke script) you test for SHELLSERVER and print an error if it is not set but then continue with the script

        Attachment #428806 -
        Flags: review?(brbaker) → review+

    
    

    
  
Comment on attachment 428806 [details] [diff] [review]
patch

- Also change the /BuildShellCommand/ to /TestSuiteShellCommand/

    
    

    
  
pushed 3909:42c3e240b197

    
    

    
  

      
      
      
      

        Attached patch
          
          
        actual patch
        — 
          — Splinter Review
      

    


  

    
    

    
  
Changed the smokes buildstep for android to be TestSuiteShellCommand
tamarin-redux - changeset - 3948:d2502cc1b180

    
    

    
  


  

        Attachment #436700 -
        Flags: review?(brbaker)

    
    

    
  
above patch fixes problem where release build errors are not marked as failures

    
    

    
  
Comment on attachment 436700 [details] [diff] [review]
patch for build-release-android-shell.sh

patch does not apply cleanly. needs to be rebased, but otherwise it is a r+

        Attachment #436700 -
        Flags: review?(brbaker) → review-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: