544479 - Compile debug winmo shell with VFP support

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect, P3)

Description

[Brent Baker]

ARM fpu is now a runtime switch (-Darm_vfp) and is not controlled by a compile time setting. Remove the switch from the cross-compile script and remove from the build system.

Comment 1

[Brent Baker]

Attachment: Remove arm-fpu from buildbot

do not need to compile a specific shell from fpu support, now a runtime switch

Comment 2

[Brent Baker]

Attachment: Remove arm-fpu from x-platform compile

Remove the --enable-arm-fpu from the cross-platform compilation script

Comment 3

[Steven Johnson]

Comment on attachment 425462 [details] [diff] [review]
Remove arm-fpu from x-platform compile

Actually, we probably want to keep this: the runtime flag controls what nanojit emits. But the compiletime flag controls what the intrinsics baked into the code itself use. Compiling (say) MathUtils.cpp without VFP support would fall back to softfloat and slow down lots of code.

In fact, we should probably add another flag to allow the compiletime ARM_ARCH setting...

Comment 4

[Brent Baker]

So should we still be compiling 2 version of the ARM shell then? 

1) without --enable-arm_fpu which we then test as a Softfloat build
2) with --enable-arm_fpu that is tested with -Darm_vfp

Comment 5

[Brent Baker]

Attachment: Compile debug shell with FPU support on winmo

Comment 6

[Brent Baker]

Comment on attachment 425462 [details] [diff] [review]
Remove arm-fpu from x-platform compile

--enable-arm-fpu needs to stay, patch is dead

Comment 7

[Brent Baker]

Comment on attachment 425489 [details] [diff] [review]
Compile debug shell with FPU support on winmo

Pushed patch:
tr-argo: 3680:1cf841782b27
tr: 3776:1cf841782b27, 3780:c5dd73a6030b