544779 - [TSF] Remove WM_USER_TSF_TEXTCHANGE

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The WM_USER_TSF_TEXTCHANGE hack should be removed. Instead of that, nsIMEStateManager should notify the content/selection changes after the change completed.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add script runners for selection/text notification

Masayuki-san, can you comment on this? This patch adds script runners for widget notifications.

Fixing this bug would be very helpful for Android.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 461990 [details] [diff] [review]
Add script runners for selection/text notification

looks great, thank you.

# Bug don't close this bug only with this patch, I'll post a patch of TSF after your patch will be landed.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 461990 [details] [diff] [review]
Add script runners for selection/text notification

Great! Can you +r? Sorry for the spam.

Comment 4

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/bb1553eca910

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Remove WM_USER_TSF_TEXTCHANGE from nsTextStore

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 8364144 [details] [diff] [review]
part.2 Remove WM_USER_TSF_TEXTCHANGE from nsTextStore

Review of attachment 8364144 [details] [diff] [review]:
-----------------------------------------------------------------

good

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/973ac6481078

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/973ac6481078