544875 - Investigate mNavigator usage in nsPluginArray and nsMimeTypeArray

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Using raw pointers is scary!

Comment 1

[Daniel Veditz [:dveditz]]

Apparently it is, Sergey Glazunov found at least one sg:critical bug in that code. Is that the only problem there or are there more?

Comment 2

[Daniel Veditz [:dveditz]]

We need this "fixed" this round to make sure bug 584517 is the only problem in there. Otherwise we're just pissing away bounties as people file them one-by-one.

Comment 3

[LegNeato]

Is there any plans to do this audit before code-freeze this Thursday? I'm going to remove blocking as we wouldn't block shipping on this audit...

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I could try to audit this tomorrow, if I find a nice solution for Bug 585815
today.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

For what it's worth, I looked into this for the patch in bug 584512 . That's why that patch touches the mime type array as well as the plugin array. I'd appreciate smaug double-checking my work though!

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Without looking at Bug 584512 I found the same bug, but not anything else.

Comment 7

[Josh Aas]

Seems like Blake and Olli are both saying they looked into this. Can we call this fixed, that being the case? Also, can we open this up as there is no specific vulnerability discussed?

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Yes.