Closed
Bug 545579
Opened 14 years ago
Closed 7 years ago
runreftest.py should allow the user to specify XPCOM_DEBUG_BREAK value
Categories
(Testing :: Reftest, enhancement)
Testing
Reftest
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Unassigned)
Details
Attachments
(1 file)
1.02 KB,
patch
|
Details | Diff | Splinter Review |
runreftest.py should allow the user to specify XPCOM_DEBUG_BREAK value I'm using runreftest.py to run reftests locally. Most often the hard-coded XPCOM_DEBUG_BREAK=stack is unwanted, because it takes significant time to generate stack traces (on Linux), so I want to be able to specify some other value.
Reporter | ||
Comment 1•14 years ago
|
||
This is what I did locally...
Comment 2•13 years ago
|
||
Note also that if you're mochitesting an opt build (possibly only with debug info enabled) and hit an assertion, "stack" means NS_StackWalk gets called, and that's total sadfaces and an instacrash at least on OS X. That could be fixed by this, or perhaps it should be fixed even if this isn't fixed.
Comment 3•7 years ago
|
||
This can be done now with, e.g `--setenv XPCOM_DEBUG_BREAK=trap`. Bz was asking about this recently as well, and mentioned there is definitely an argument to be made for *not* using the value in the OS environment. Mats, given the above workaround and bz's concern, are you ok with WONTFIXING this?
Flags: needinfo?(mats)
Reporter | ||
Comment 4•7 years ago
|
||
Absolutely. I'd call it fixed even. I was only looking for some way to conveniently avoid the perf hit of the assertion stack walks. FTR, another way of doing this now is "mach ... --debugger=gdb" and then have "set environment XPCOM_DEBUG_BREAK=trap" (or some other value like "warn") in your $HOME/.gdbinit Anyway, --setenv looks good. Thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(mats)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•