545771 - Double accesskey 'n' for 'Unsubscribe' and 'Preferences' for newsgroups [linux]

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Karsten Düsterloh]

Shredder 3.0.2pre, Linux 64 bit debug build.

steps to reproduce:
- select newsgroup and make sure it has the focus 
- hit alt-e to open the Edit menu
- hit n to open Preferences

expected result:
Preferences dialog opens

actual result:
'Unsubscribe' menuitem is selected, you need hit n again to select the Prefences entry and hit return to open the Preferences dialog

possible solution:
switch Preferences accesskey to e again?

Comment 1

[:aceman]

Or change the access key of the less common Unsubscribe item?

Comment 2

[:aceman]

I am able to change accesskeys, I just need a UI decision here.

Comment 3

[:aceman]

Ian Neal, is this relevant for Seamonkey too? It also uses "n" for Unsubscribe but I do not know what other menu items are there and if it clashes with anything.

My suggestion for Thunderbird is to change unsubscribeNewsgroupCmd.accesskey to 'b' as that is not yet used in the Edit menu.
I think it is better to change accesskey for the Unsubscribe command instead of Preferences. Preferences is always there and probably more known so keeping it unchanged is higher gain.

Comment 4

[Ian Neal]

(In reply to :aceman from comment #3)
> Ian Neal, is this relevant for Seamonkey too? It also uses "n" for
> Unsubscribe but I do not know what other menu items are there and if it
> clashes with anything.
> 
> My suggestion for Thunderbird is to change unsubscribeNewsgroupCmd.accesskey
> to 'b' as that is not yet used in the Edit menu.
> I think it is better to change accesskey for the Unsubscribe command instead
> of Preferences. Preferences is always there and probably more known so
> keeping it unchanged is higher gain.

e is used for Preferences on SM. SM uses a different preferences dialog and nothing on any of the pref panes that is opened uses "e" as an accesskey, so I'm not sure if SM is affected. Karsten might know though.

Comment 5

[:aceman]

This is talking only about Edit menu. If your Preferences menu item does not use "n" then you are not affected and I will not touch SM. Thanks.

Comment 6

[:aceman]

Attachment: patch

Change accesskey for Unsubscribe to 'b'. Reasoning in comment 3.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 592820 [details] [diff] [review]
patch

Seems reasonable, and reasonably well thought-out.

ui-r=me, and since I'm here, r=me, too.

Thanks,
Blake.

Comment 8

[:aceman]

Thanks!

Comment 9

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/37481eaa6c69