546006 - [Fx] Crashreporter dialog is too narrow for the text

Status: RESOLVED DUPLICATE of bug 528800

(Mozilla Localizations :: de / German, defect)

Description

[Kadir Topal [:atopal]]

Attachment: Crashreporter dialog is too narrow for the text

The text in the crashreporter dialog is cut, because the dialog doesn't resize and the text doesn't break.

Comment 1

[Kadir Topal [:atopal]]

Axel, is there a way to resize the crash reporter dialog? The size is okay for windows

Comment 2

[Kadir Topal [:atopal]]

Attachment: windows dialog, right size

Comment 3

[Kadir Topal [:atopal]]

Hey Ted, can you comment?

Comment 4

[(not currently active) Ted Mielczarek]

We have code that's supposed to handle this, I'm not sure why it's not working:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter_osx.mm#435

Comment 5

[Kadir Topal [:atopal]]

Ted, can I assign this to you? It's assigned to me, but there is not much I can do as a localizer.

Comment 6

[(not currently active) Ted Mielczarek]

I don't think I have time to investigate this at the moment. :-/ Maybe you could rope someone with Win32 knowledge in to look at this?

Comment 7

[Kadir Topal [:atopal]]

Honestly, I wouldn't know whom to talk to. But as it sits here, no one will have a look at this. German is the second biggest locale after English, it's already embarrassing when Firefox crashes, but this broken window is doubly so.

Ted, can you suggest anyone I should ping about this?

Comment 8

[(not currently active) Ted Mielczarek]

Oh, I'm sorry, this is on Mac. I asked on #macdev, but it's pretty sparse. I'm sorry, I don't have any other great ideas. :-(

Comment 9

[Kadir Topal [:atopal]]

Okay, thanks Ted.

Axel, can you comment on what to do here?

Comment 10

[Axel Hecht [:Pike]]

So, I don't know either, the original patch is actually by Ted ;-)

I dug a bit in, and found http://stackoverflow.com/questions/6692016/cocoa-animated-frame-in-preference-window, which says 

[window setFrame:windowFrame display:YES animate:YES];

whereas our code says

[mWindow setFrame:windowFrame display: true animate: NO];

Reading cocoa docs, it seems that "YES" is bool, and "true" is not? CCing Josh who probably knows, I'm just stabbing at dust.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

As far as I can see, the code hasn't been touched: http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter_osx.mm#159

Josh, would altering it from
     [mWindow setFrame:frame display: true animate:NO];
to
     [mWindow setFrame:frame display:YES animate:NO];
fix the issue? See comment 10.

Comment 12

[(not currently active) Ted Mielczarek]

That code is definitely not correct as written:
https://developer.apple.com/library/mac/documentation/cocoa/reference/applicationkit/classes/NSWindow_Class/Reference/Reference.html

I don't know if changing that will fix the bug or not, but it's worth a shot.

Comment 13

[Francesco Lodolo [:flod]]

I think this is a dupe of bug 528800.

Comment 14

[Josh Aas]

Definitely change the "true" to "YES". As to whether or not that will fix the bug I don't know, but I doubt it.